Re: [PATCH] keyspan: init termios properly

2007-12-02 Thread Borislav Petkov
On Sun, Dec 02, 2007 at 01:57:34PM +, Alan Cox wrote: > On Sun, 2 Dec 2007 09:03:40 +0100 > Borislav Petkov <[EMAIL PROTECTED]> wrote: > > > On Fri, Nov 30, 2007 at 09:23:43AM -0800, Lucy McCoy wrote: > > > Hi All, > > > > > > I've been too busy to get to this but i'd rather not use the code

Re: [PATCH] keyspan: init termios properly

2007-12-02 Thread Alan Cox
On Sun, 2 Dec 2007 09:03:40 +0100 Borislav Petkov <[EMAIL PROTECTED]> wrote: > On Fri, Nov 30, 2007 at 09:23:43AM -0800, Lucy McCoy wrote: > > Hi All, > > > > I've been too busy to get to this but i'd rather not use the code fragment > > i sent Boris to try. It would be better to go ahead with

Re: [PATCH] keyspan: init termios properly

2007-12-02 Thread Borislav Petkov
On Fri, Nov 30, 2007 at 09:23:43AM -0800, Lucy McCoy wrote: > Hi All, > > I've been too busy to get to this but i'd rather not use the code fragment > i sent Boris to try. It would be better to go ahead with the tty setup if > the pointer is not NULL, otherwise use the defaults and not

Re: [PATCH] keyspan: init termios properly

2007-12-02 Thread Borislav Petkov
On Fri, Nov 30, 2007 at 09:23:43AM -0800, Lucy McCoy wrote: Hi All, I've been too busy to get to this but i'd rather not use the code fragment i sent Boris to try. It would be better to go ahead with the tty setup if the pointer is not NULL, otherwise use the defaults and not reference the

Re: [PATCH] keyspan: init termios properly

2007-12-02 Thread Alan Cox
On Sun, 2 Dec 2007 09:03:40 +0100 Borislav Petkov [EMAIL PROTECTED] wrote: On Fri, Nov 30, 2007 at 09:23:43AM -0800, Lucy McCoy wrote: Hi All, I've been too busy to get to this but i'd rather not use the code fragment i sent Boris to try. It would be better to go ahead with the tty

Re: [PATCH] keyspan: init termios properly

2007-12-02 Thread Borislav Petkov
On Sun, Dec 02, 2007 at 01:57:34PM +, Alan Cox wrote: On Sun, 2 Dec 2007 09:03:40 +0100 Borislav Petkov [EMAIL PROTECTED] wrote: On Fri, Nov 30, 2007 at 09:23:43AM -0800, Lucy McCoy wrote: Hi All, I've been too busy to get to this but i'd rather not use the code fragment

Re: [PATCH] keyspan: init termios properly

2007-11-30 Thread Lucy McCoy
Hi All, I've been too busy to get to this but i'd rather not use the code fragment i sent Boris to try. It would be better to go ahead with the tty setup if the pointer is not NULL, otherwise use the defaults and not reference the NULL pointer. I'll see if I can get to this today. Lucy

Re: [PATCH] keyspan: init termios properly

2007-11-30 Thread Lucy McCoy
Hi All, I've been too busy to get to this but i'd rather not use the code fragment i sent Boris to try. It would be better to go ahead with the tty setup if the pointer is not NULL, otherwise use the defaults and not reference the NULL pointer. I'll see if I can get to this today. Lucy

Re: [PATCH] keyspan: init termios properly

2007-11-29 Thread Borislav Petkov
On Mon, Nov 26, 2007 at 02:18:52PM -0800, Andrew Morton wrote: > On Sun, 18 Nov 2007 14:11:30 +0100 > Borislav Petkov <[EMAIL PROTECTED]> wrote: > > > On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote: ... > > yes, after testing this i can confirm that this one fixes the NULL ptr > >

Re: [PATCH] keyspan: init termios properly

2007-11-29 Thread Borislav Petkov
On Mon, Nov 26, 2007 at 02:18:52PM -0800, Andrew Morton wrote: On Sun, 18 Nov 2007 14:11:30 +0100 Borislav Petkov [EMAIL PROTECTED] wrote: On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote: ... yes, after testing this i can confirm that this one fixes the NULL ptr problem here

Re: [PATCH] keyspan: init termios properly

2007-11-26 Thread Andrew Morton
On Sun, 18 Nov 2007 14:11:30 +0100 Borislav Petkov <[EMAIL PROTECTED]> wrote: > On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote: > > > static int keyspan_open (struct usb_serial_port *port, struct file *filp) > > { > > struct keyspan_port_private *p_priv; > > struct

Re: [PATCH] keyspan: init termios properly

2007-11-26 Thread Andrew Morton
On Sun, 18 Nov 2007 14:11:30 +0100 Borislav Petkov [EMAIL PROTECTED] wrote: On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote: static int keyspan_open (struct usb_serial_port *port, struct file *filp) { struct keyspan_port_private *p_priv; struct

Re: [PATCH] keyspan: init termios properly

2007-11-18 Thread Borislav Petkov
On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote: > static int keyspan_open (struct usb_serial_port *port, struct file *filp) > { > struct keyspan_port_private *p_priv; > struct keyspan_serial_private *s_priv; > struct usb_serial *serial =

Re: [PATCH] keyspan: init termios properly

2007-11-18 Thread Borislav Petkov
On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote: static int keyspan_open (struct usb_serial_port *port, struct file *filp) { struct keyspan_port_private *p_priv; struct keyspan_serial_private *s_priv; struct usb_serial *serial = port-serial;

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Borislav Petkov
On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote: Hi Lucy, > I'm not familiar with the termios stuff on Linux so can you take a look > at the following modified code to see if this solves your NULL ptr problem? will test the patch tomorrow and get back to you with results. > Does

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Lucy McCoy
Thursday, November 15, 2007 12:40pm To: Lucy McCoy <[EMAIL PROTECTED]> Cc: Greg KH <[EMAIL PROTECTED]>, linux-kernel@vger.kernel.org, Andrew Morton <[EMAIL PROTECTED]> Subject: Re: [PATCH] keyspan: init termios properly On Thu, Nov 15, 2007 at 09:49:22AM -0800, Lucy McCoy wrote: >

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Borislav Petkov
On Thu, Nov 15, 2007 at 09:49:22AM -0800, Lucy McCoy wrote: > Greg & Boris, > > I've been out of town and just saw this. > > This patch will work with the 19HS but WILL BREAK all other Keyspan > adapters. It will take me a few days to get to looking at a correct fix but > that

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Lucy McCoy
Yes, it will break things. I'll try to get to it soon... Andrew Morton wrote: On Thu, 15 Nov 2007 09:49:22 -0800 Lucy McCoy <[EMAIL PROTECTED]> wrote: Greg & Boris, I've been out of town and just saw this. This patch will work with the 19HS but WILL BREAK all other Keyspan adapters. It

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 09:49:22 -0800 Lucy McCoy <[EMAIL PROTECTED]> wrote: > Greg & Boris, > > I've been out of town and just saw this. > > This patch will work with the 19HS but WILL BREAK all other Keyspan > adapters. It will take me a few days to get to looking at a correct fix but > that

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Lucy McCoy
Greg & Boris, I've been out of town and just saw this. This patch will work with the 19HS but WILL BREAK all other Keyspan adapters. It will take me a few days to get to looking at a correct fix but that keyspan_send_setup(port, 1) (and the '1' is the important part) must happen once when the

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Lucy McCoy
Greg Boris, I've been out of town and just saw this. This patch will work with the 19HS but WILL BREAK all other Keyspan adapters. It will take me a few days to get to looking at a correct fix but that keyspan_send_setup(port, 1) (and the '1' is the important part) must happen once when the

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 09:49:22 -0800 Lucy McCoy [EMAIL PROTECTED] wrote: Greg Boris, I've been out of town and just saw this. This patch will work with the 19HS but WILL BREAK all other Keyspan adapters. It will take me a few days to get to looking at a correct fix but that

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Lucy McCoy
Yes, it will break things. I'll try to get to it soon... Andrew Morton wrote: On Thu, 15 Nov 2007 09:49:22 -0800 Lucy McCoy [EMAIL PROTECTED] wrote: Greg Boris, I've been out of town and just saw this. This patch will work with the 19HS but WILL BREAK all other Keyspan adapters. It

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Borislav Petkov
On Thu, Nov 15, 2007 at 09:49:22AM -0800, Lucy McCoy wrote: Greg Boris, I've been out of town and just saw this. This patch will work with the 19HS but WILL BREAK all other Keyspan adapters. It will take me a few days to get to looking at a correct fix but that keyspan_send_setup(port, 1)

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Lucy McCoy
Morton [EMAIL PROTECTED] Subject: Re: [PATCH] keyspan: init termios properly On Thu, Nov 15, 2007 at 09:49:22AM -0800, Lucy McCoy wrote: Greg Boris, I've been out of town and just saw this. This patch will work with the 19HS but WILL BREAK all other Keyspan adapters. It will take me a few

Re: [PATCH] keyspan: init termios properly

2007-11-15 Thread Borislav Petkov
On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote: Hi Lucy, I'm not familiar with the termios stuff on Linux so can you take a look at the following modified code to see if this solves your NULL ptr problem? will test the patch tomorrow and get back to you with results. Does cflag

[PATCH] keyspan: init termios properly

2007-11-03 Thread Borislav Petkov
Hi Greg, i get the following backtrace when booting the kernel with "console=ttyUSB0 console=tty0" while using a Keyspan USA-19HS the usb-to-serial converter connected to a desktop machine: [ 43.782384] usbcore: registered new interface driver usbserial [ 43.782444]

[PATCH] keyspan: init termios properly

2007-11-03 Thread Borislav Petkov
Hi Greg, i get the following backtrace when booting the kernel with console=ttyUSB0 console=tty0 while using a Keyspan USA-19HS the usb-to-serial converter connected to a desktop machine: snip [ 43.782384] usbcore: registered new interface driver usbserial [ 43.782444]