Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 10:48:11AM -0800, Arjan van de Ven wrote: > On Thu, 31 Jan 2008 19:34:25 +0100 > Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote: > > > On Thu, 31 Jan 2008 19:14:36 +0200 > > > Adrian Bunk <[EMAIL PROTECTED]>

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Geert Uytterhoeven
On Thu, 31 Jan 2008, Chris Wedgwood wrote: > On Thu, Jan 31, 2008 at 07:55:43PM +0200, Adrian Bunk wrote: > > Who was talking about laptops? > > If laptops are mostly MP these days, then 'desktops' and 'servers' > certainly are --- so pretty much everyone needs CPU hotplug. Thank you for giving

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
On Thu, 31 Jan 2008 19:34:25 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote: > > On Thu, 31 Jan 2008 19:14:36 +0200 > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > cpuhotplug is required for suspend/resume. > > > > > > Not on

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Chris Wedgwood
On Thu, Jan 31, 2008 at 07:55:43PM +0200, Adrian Bunk wrote: > Who was talking about laptops? If laptops are mostly MP these days, then 'desktops' and 'servers' certainly are --- so pretty much everyone needs CPU hotplug. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote: > On Thu, 31 Jan 2008 19:14:36 +0200 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > cpuhotplug is required for suspend/resume. > > > > Not on UP computers. > > > > great! someone who still has one of those and uses a kernel

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Adrian Bunk
On Thu, Jan 31, 2008 at 09:45:26AM -0800, Chris Wedgwood wrote: > On Thu, Jan 31, 2008 at 07:14:36PM +0200, Adrian Bunk wrote: > > > > cpuhotplug is required for suspend/resume. > > > > Not on UP computers. > > those are less and less common now, most modern laptops are dual core Who was

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
On Thu, 31 Jan 2008 19:14:36 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > > cpuhotplug is required for suspend/resume. > > Not on UP computers. > great! someone who still has one of those and uses a kernel without it. Can you look at your system.map and see how many kilobytes you've gained?

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Chris Wedgwood
On Thu, Jan 31, 2008 at 07:14:36PM +0200, Adrian Bunk wrote: > > cpuhotplug is required for suspend/resume. > > Not on UP computers. those are less and less common now, most modern laptops are dual core -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Adrian Bunk
On Thu, Jan 31, 2008 at 09:07:49AM -0800, Arjan van de Ven wrote: > On Thu, 31 Jan 2008 18:21:42 +0200 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote: > > > On Thu, 31 Jan 2008 09:57:31 -0600 > > > James Bottomley <[EMAIL

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
On Thu, 31 Jan 2008 18:21:42 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote: > > On Thu, 31 Jan 2008 09:57:31 -0600 > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > No-one seems to see much value in these, and they cause

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Adrian Bunk
On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote: > On Thu, 31 Jan 2008 09:57:31 -0600 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > No-one seems to see much value in these, and they cause about 90% of > > our problems with __init/__exit markers, so simply eliminate them. > >

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
On Thu, 31 Jan 2008 09:57:31 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > No-one seems to see much value in these, and they cause about 90% of > our problems with __init/__exit markers, so simply eliminate them. > Rather than run over the whole tree removing them, this patch > #defines them

[PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread James Bottomley
No-one seems to see much value in these, and they cause about 90% of our problems with __init/__exit markers, so simply eliminate them. Rather than run over the whole tree removing them, this patch #defines them to be nops. Signed-off-by: James Bottomley <[EMAIL PROTECTED]> --- I'll probably

[PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread James Bottomley
No-one seems to see much value in these, and they cause about 90% of our problems with __init/__exit markers, so simply eliminate them. Rather than run over the whole tree removing them, this patch #defines them to be nops. Signed-off-by: James Bottomley [EMAIL PROTECTED] --- I'll probably be

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Adrian Bunk
On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote: On Thu, 31 Jan 2008 09:57:31 -0600 James Bottomley [EMAIL PROTECTED] wrote: No-one seems to see much value in these, and they cause about 90% of our problems with __init/__exit markers, so simply eliminate them. Rather

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
On Thu, 31 Jan 2008 09:57:31 -0600 James Bottomley [EMAIL PROTECTED] wrote: No-one seems to see much value in these, and they cause about 90% of our problems with __init/__exit markers, so simply eliminate them. Rather than run over the whole tree removing them, this patch #defines them to be

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Adrian Bunk
On Thu, Jan 31, 2008 at 09:07:49AM -0800, Arjan van de Ven wrote: On Thu, 31 Jan 2008 18:21:42 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote: On Thu, 31 Jan 2008 09:57:31 -0600 James Bottomley [EMAIL PROTECTED] wrote:

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
On Thu, 31 Jan 2008 18:21:42 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: On Thu, Jan 31, 2008 at 08:11:20AM -0800, Arjan van de Ven wrote: On Thu, 31 Jan 2008 09:57:31 -0600 James Bottomley [EMAIL PROTECTED] wrote: No-one seems to see much value in these, and they cause about 90% of

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Chris Wedgwood
On Thu, Jan 31, 2008 at 07:14:36PM +0200, Adrian Bunk wrote: cpuhotplug is required for suspend/resume. Not on UP computers. those are less and less common now, most modern laptops are dual core -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
On Thu, 31 Jan 2008 19:14:36 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: cpuhotplug is required for suspend/resume. Not on UP computers. great! someone who still has one of those and uses a kernel without it. Can you look at your system.map and see how many kilobytes you've gained? Eg how

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Adrian Bunk
On Thu, Jan 31, 2008 at 09:45:26AM -0800, Chris Wedgwood wrote: On Thu, Jan 31, 2008 at 07:14:36PM +0200, Adrian Bunk wrote: cpuhotplug is required for suspend/resume. Not on UP computers. those are less and less common now, most modern laptops are dual core Who was talking about

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Arjan van de Ven
On Thu, 31 Jan 2008 19:34:25 +0100 Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote: On Thu, 31 Jan 2008 19:14:36 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: cpuhotplug is required for suspend/resume. Not on UP computers.

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote: On Thu, 31 Jan 2008 19:14:36 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: cpuhotplug is required for suspend/resume. Not on UP computers. great! someone who still has one of those and uses a kernel without it. Can you

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Chris Wedgwood
On Thu, Jan 31, 2008 at 07:55:43PM +0200, Adrian Bunk wrote: Who was talking about laptops? If laptops are mostly MP these days, then 'desktops' and 'servers' certainly are --- so pretty much everyone needs CPU hotplug. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Geert Uytterhoeven
On Thu, 31 Jan 2008, Chris Wedgwood wrote: On Thu, Jan 31, 2008 at 07:55:43PM +0200, Adrian Bunk wrote: Who was talking about laptops? If laptops are mostly MP these days, then 'desktops' and 'servers' certainly are --- so pretty much everyone needs CPU hotplug. irony Thank you for giving

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 10:48:11AM -0800, Arjan van de Ven wrote: On Thu, 31 Jan 2008 19:34:25 +0100 Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote: On Thu, 31 Jan 2008 19:14:36 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: