Re: [PATCH] leds/trigger: system can't enter suspend.

2017-05-10 Thread Jacek Anaszewski
Hi Zhang, Thanks for the patch. I'd rather keep sending uevent on setting trigger to "none". We could get rid of the problem you're trying to fix, by modifying heartbeat_pm_notifier() so that it didn't go through the whole procedure of unregistering/registering the trigger on suspend/resume.

Re: [PATCH] leds/trigger: system can't enter suspend.

2017-05-10 Thread Jacek Anaszewski
Hi Zhang, Thanks for the patch. I'd rather keep sending uevent on setting trigger to "none". We could get rid of the problem you're trying to fix, by modifying heartbeat_pm_notifier() so that it didn't go through the whole procedure of unregistering/registering the trigger on suspend/resume.

Re: [PATCH] leds/trigger: system can't enter suspend.

2017-05-07 Thread Pavel Machek
On Sun 2017-05-07 10:01:21, sanshan zhang wrote: > From: zhang sanshan > > system can't enter suspend when enable led heartbeat. > > pm will call heartbeat_pm_notifier when suspend. > system will prepare led states, and led_trigger_unregister > will use led_trigger_set to

Re: [PATCH] leds/trigger: system can't enter suspend.

2017-05-07 Thread Pavel Machek
On Sun 2017-05-07 10:01:21, sanshan zhang wrote: > From: zhang sanshan > > system can't enter suspend when enable led heartbeat. > > pm will call heartbeat_pm_notifier when suspend. > system will prepare led states, and led_trigger_unregister > will use led_trigger_set to set trigger. >

RE: [PATCH] leds/trigger: system can't enter suspend.

2017-05-07 Thread Pete Zhang
: system can't enter suspend. On Sun 2017-05-07 10:01:21, sanshan zhang wrote: > From: zhang sanshan <sanshan.zh...@nxp.com> > > system can't enter suspend when enable led heartbeat. > > pm will call heartbeat_pm_notifier when suspend. > system will prepare led states, an

RE: [PATCH] leds/trigger: system can't enter suspend.

2017-05-07 Thread Pete Zhang
: system can't enter suspend. On Sun 2017-05-07 10:01:21, sanshan zhang wrote: > From: zhang sanshan > > system can't enter suspend when enable led heartbeat. > > pm will call heartbeat_pm_notifier when suspend. > system will prepare led states, and led_trigger_unregister will use

[PATCH] leds/trigger: system can't enter suspend.

2017-05-07 Thread sanshan zhang
From: zhang sanshan system can't enter suspend when enable led heartbeat. pm will call heartbeat_pm_notifier when suspend. system will prepare led states, and led_trigger_unregister will use led_trigger_set to set trigger. kobject_uevent_env will send event,it will call

[PATCH] leds/trigger: system can't enter suspend.

2017-05-07 Thread sanshan zhang
From: zhang sanshan system can't enter suspend when enable led heartbeat. pm will call heartbeat_pm_notifier when suspend. system will prepare led states, and led_trigger_unregister will use led_trigger_set to set trigger. kobject_uevent_env will send event,it will call ep_poll_callback to hold