Re: [PATCH] leds: core: Use blocking op for system suspend

2020-07-01 Thread Kai-Heng Feng
> On Jul 2, 2020, at 05:28, Jacek Anaszewski wrote: > > Hi Kai-Heng, > > Thank you for the patch. > > On 7/1/20 11:35 AM, Kai-Heng Feng wrote: >> Sometimes LED won't be turned off by LED_CORE_SUSPENDRESUME flag upon >> system suspend. > > Just out of curiosity - are you experiencing that

Re: [PATCH] leds: core: Use blocking op for system suspend

2020-07-01 Thread Jacek Anaszewski
Hi Kai-Heng, Thank you for the patch. On 7/1/20 11:35 AM, Kai-Heng Feng wrote: Sometimes LED won't be turned off by LED_CORE_SUSPENDRESUME flag upon system suspend. Just out of curiosity - are you experiencing that on some hardware? led_set_brightness_nopm() uses schedule_work() to set LED

[PATCH] leds: core: Use blocking op for system suspend

2020-07-01 Thread Kai-Heng Feng
Sometimes LED won't be turned off by LED_CORE_SUSPENDRESUME flag upon system suspend. led_set_brightness_nopm() uses schedule_work() to set LED brightness. However, there's no guarantee that the scheduled work gets executed because no one calls flush_scheduled_work(). As flush_scheduled_work()