Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-18 Thread Vaishali Thakkar
On Tue, Aug 18, 2015 at 6:06 PM, Jacek Anaszewski wrote: > On 08/18/2015 02:14 PM, Vaishali Thakkar wrote: >> >> On Tue, Aug 18, 2015 at 12:57 PM, Jacek Anaszewski >> wrote: >>> >>> Hi Vaishali, >>> >>> On 08/18/2015 07:46 AM, Vaishali Thakkar wrote: On Mon, Aug 17, 2015 at 2:02

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-18 Thread Jacek Anaszewski
On 08/18/2015 02:14 PM, Vaishali Thakkar wrote: On Tue, Aug 18, 2015 at 12:57 PM, Jacek Anaszewski wrote: Hi Vaishali, On 08/18/2015 07:46 AM, Vaishali Thakkar wrote: On Mon, Aug 17, 2015 at 2:02 PM, Vaishali Thakkar wrote: On 17 Aug 2015 13:57, "Jacek Anaszewski" wrote: Hi

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-18 Thread Vaishali Thakkar
On Tue, Aug 18, 2015 at 12:57 PM, Jacek Anaszewski wrote: > Hi Vaishali, > > On 08/18/2015 07:46 AM, Vaishali Thakkar wrote: >> >> On Mon, Aug 17, 2015 at 2:02 PM, Vaishali Thakkar >> wrote: >>> >>> >>> On 17 Aug 2015 13:57, "Jacek Anaszewski" >>> wrote: Hi Vaishali,

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-18 Thread Jacek Anaszewski
Hi Vaishali, On 08/18/2015 07:46 AM, Vaishali Thakkar wrote: On Mon, Aug 17, 2015 at 2:02 PM, Vaishali Thakkar wrote: On 17 Aug 2015 13:57, "Jacek Anaszewski" wrote: Hi Vaishali, Thanks for the patch. Unfortunately it causes build break. Please fix the issues and resubmit. Oops! I am

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-18 Thread Jacek Anaszewski
Hi Vaishali, On 08/18/2015 07:46 AM, Vaishali Thakkar wrote: On Mon, Aug 17, 2015 at 2:02 PM, Vaishali Thakkar vthakkar1...@gmail.com wrote: On 17 Aug 2015 13:57, Jacek Anaszewski j.anaszew...@samsung.com wrote: Hi Vaishali, Thanks for the patch. Unfortunately it causes build break. Please

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-18 Thread Jacek Anaszewski
On 08/18/2015 02:14 PM, Vaishali Thakkar wrote: On Tue, Aug 18, 2015 at 12:57 PM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Hi Vaishali, On 08/18/2015 07:46 AM, Vaishali Thakkar wrote: On Mon, Aug 17, 2015 at 2:02 PM, Vaishali Thakkar vthakkar1...@gmail.com wrote: On 17 Aug 2015

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-18 Thread Vaishali Thakkar
On Tue, Aug 18, 2015 at 12:57 PM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Hi Vaishali, On 08/18/2015 07:46 AM, Vaishali Thakkar wrote: On Mon, Aug 17, 2015 at 2:02 PM, Vaishali Thakkar vthakkar1...@gmail.com wrote: On 17 Aug 2015 13:57, Jacek Anaszewski j.anaszew...@samsung.com

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-18 Thread Vaishali Thakkar
On Tue, Aug 18, 2015 at 6:06 PM, Jacek Anaszewski j.anaszew...@samsung.com wrote: On 08/18/2015 02:14 PM, Vaishali Thakkar wrote: On Tue, Aug 18, 2015 at 12:57 PM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Hi Vaishali, On 08/18/2015 07:46 AM, Vaishali Thakkar wrote: On Mon, Aug

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-17 Thread Vaishali Thakkar
On Mon, Aug 17, 2015 at 2:02 PM, Vaishali Thakkar wrote: > > On 17 Aug 2015 13:57, "Jacek Anaszewski" wrote: >> >> Hi Vaishali, >> >> Thanks for the patch. Unfortunately it causes build break. >> Please fix the issues and resubmit. > > Oops! I am really very sorry. By mistake I sent a basic

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-17 Thread Jacek Anaszewski
Hi Vaishali, Thanks for the patch. Unfortunately it causes build break. Please fix the issues and resubmit. On 08/15/2015 12:21 PM, Vaishali Thakkar wrote: Use resource-managed function devm_led_classdev_register instead of led_classdev_register to make the error-path simpler. To be

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-17 Thread Vaishali Thakkar
On Mon, Aug 17, 2015 at 2:02 PM, Vaishali Thakkar vthakkar1...@gmail.com wrote: On 17 Aug 2015 13:57, Jacek Anaszewski j.anaszew...@samsung.com wrote: Hi Vaishali, Thanks for the patch. Unfortunately it causes build break. Please fix the issues and resubmit. Oops! I am really very sorry.

Re: [PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-17 Thread Jacek Anaszewski
Hi Vaishali, Thanks for the patch. Unfortunately it causes build break. Please fix the issues and resubmit. On 08/15/2015 12:21 PM, Vaishali Thakkar wrote: Use resource-managed function devm_led_classdev_register instead of led_classdev_register to make the error-path simpler. To be

[PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-15 Thread Vaishali Thakkar
Use resource-managed function devm_led_classdev_register instead of led_classdev_register to make the error-path simpler. To be compatible with the change, various gotos are replced with direct returns and unneeded labels are dropped. Also, remove fsg_led_remove as it is now redundant.

[PATCH] leds: leds-fsg: Use devm_led_classdev_register

2015-08-15 Thread Vaishali Thakkar
Use resource-managed function devm_led_classdev_register instead of led_classdev_register to make the error-path simpler. To be compatible with the change, various gotos are replced with direct returns and unneeded labels are dropped. Also, remove fsg_led_remove as it is now redundant.