Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Geert Uytterhoeven
On Thu, Nov 6, 2014 at 12:22 PM, Mika Westerberg wrote: > On Thu, Nov 06, 2014 at 12:12:04PM +0100, Geert Uytterhoeven wrote: >> On Thu, Nov 6, 2014 at 11:58 AM, Mika Westerberg >> wrote: >> > On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert Uytterhoeven wrote: >> >> On Thu, Nov 6, 2014 at 11:30

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Mika Westerberg
On Thu, Nov 06, 2014 at 12:12:04PM +0100, Geert Uytterhoeven wrote: > Hi Mika, > > On Thu, Nov 6, 2014 at 11:58 AM, Mika Westerberg > wrote: > > On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert Uytterhoeven wrote: > >> On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg > >> wrote: > >> >> "leds:

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Geert Uytterhoeven
Hi Mika, On Thu, Nov 6, 2014 at 11:58 AM, Mika Westerberg wrote: > On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert Uytterhoeven wrote: >> On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg >> wrote: >> >> "leds: leds-gpio: Add support for GPIO descriptors" broke leds-gpio on >> >> non-DT

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Mika Westerberg
On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert Uytterhoeven wrote: > Hi Mika, > > On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg > wrote: > >> "leds: leds-gpio: Add support for GPIO descriptors" broke leds-gpio on > >> non-DT platforms for me: > >> > >> gpiod_direction_output: invalid

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Geert Uytterhoeven
Hi Mika, On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg wrote: >> "leds: leds-gpio: Add support for GPIO descriptors" broke leds-gpio on >> non-DT platforms for me: >> >> gpiod_direction_output: invalid GPIO >> leds-gpio: probe of leds-gpio failed with error -22 >> >> (desc is NULL in

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Mika Westerberg
On Thu, Nov 06, 2014 at 10:52:35AM +0100, Geert Uytterhoeven wrote: > Hi Mika, Rafael, > > On Tue, Nov 4, 2014 at 11:50 PM, Rafael J. Wysocki wrote: > > On Tuesday, November 04, 2014 12:10:41 PM Alexandre Courbot wrote: > >> On 10/31/2014 08:40 PM, Mika Westerberg wrote: > >> > Commit

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Geert Uytterhoeven
Hi Mika, Rafael, On Tue, Nov 4, 2014 at 11:50 PM, Rafael J. Wysocki wrote: > On Tuesday, November 04, 2014 12:10:41 PM Alexandre Courbot wrote: >> On 10/31/2014 08:40 PM, Mika Westerberg wrote: >> > Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO >> > descriptors") already

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Geert Uytterhoeven
Hi Mika, Rafael, On Tue, Nov 4, 2014 at 11:50 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Tuesday, November 04, 2014 12:10:41 PM Alexandre Courbot wrote: On 10/31/2014 08:40 PM, Mika Westerberg wrote: Commit 21f2aae91e902aad (leds: leds-gpio: Add support for GPIO descriptors) already

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Mika Westerberg
On Thu, Nov 06, 2014 at 10:52:35AM +0100, Geert Uytterhoeven wrote: Hi Mika, Rafael, On Tue, Nov 4, 2014 at 11:50 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Tuesday, November 04, 2014 12:10:41 PM Alexandre Courbot wrote: On 10/31/2014 08:40 PM, Mika Westerberg wrote: Commit

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Geert Uytterhoeven
Hi Mika, On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: leds: leds-gpio: Add support for GPIO descriptors broke leds-gpio on non-DT platforms for me: gpiod_direction_output: invalid GPIO leds-gpio: probe of leds-gpio failed with error -22

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Mika Westerberg
On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert Uytterhoeven wrote: Hi Mika, On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: leds: leds-gpio: Add support for GPIO descriptors broke leds-gpio on non-DT platforms for me:

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Geert Uytterhoeven
Hi Mika, On Thu, Nov 6, 2014 at 11:58 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert Uytterhoeven wrote: On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: leds: leds-gpio: Add support for GPIO

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Mika Westerberg
On Thu, Nov 06, 2014 at 12:12:04PM +0100, Geert Uytterhoeven wrote: Hi Mika, On Thu, Nov 6, 2014 at 11:58 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert Uytterhoeven wrote: On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-06 Thread Geert Uytterhoeven
On Thu, Nov 6, 2014 at 12:22 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Nov 06, 2014 at 12:12:04PM +0100, Geert Uytterhoeven wrote: On Thu, Nov 6, 2014 at 11:58 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Nov 06, 2014 at 11:32:19AM +0100, Geert

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-04 Thread Rafael J. Wysocki
On Tuesday, November 04, 2014 12:10:41 PM Alexandre Courbot wrote: > On 10/31/2014 08:40 PM, Mika Westerberg wrote: > > Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO > > descriptors") already converted most of the driver to use GPIO descriptors. > > What is still missing is the

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-04 Thread Rafael J. Wysocki
On Tuesday, November 04, 2014 12:10:41 PM Alexandre Courbot wrote: On 10/31/2014 08:40 PM, Mika Westerberg wrote: Commit 21f2aae91e902aad (leds: leds-gpio: Add support for GPIO descriptors) already converted most of the driver to use GPIO descriptors. What is still missing is the platform

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-03 Thread Alexandre Courbot
On 10/31/2014 08:40 PM, Mika Westerberg wrote: Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO descriptors") already converted most of the driver to use GPIO descriptors. What is still missing is the platform specific hook gpio_blink_set() and board files which pass legacy GPIO

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-03 Thread Linus Walleij
On Fri, Oct 31, 2014 at 12:40 PM, Mika Westerberg wrote: > Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO > descriptors") already converted most of the driver to use GPIO descriptors. > What is still missing is the platform specific hook gpio_blink_set() and > board files which

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-03 Thread Linus Walleij
On Fri, Oct 31, 2014 at 12:40 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Commit 21f2aae91e902aad (leds: leds-gpio: Add support for GPIO descriptors) already converted most of the driver to use GPIO descriptors. What is still missing is the platform specific hook

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-11-03 Thread Alexandre Courbot
On 10/31/2014 08:40 PM, Mika Westerberg wrote: Commit 21f2aae91e902aad (leds: leds-gpio: Add support for GPIO descriptors) already converted most of the driver to use GPIO descriptors. What is still missing is the platform specific hook gpio_blink_set() and board files which pass legacy GPIO

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-10-31 Thread Andrew Lunn
On Fri, Oct 31, 2014 at 01:40:58PM +0200, Mika Westerberg wrote: > Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO > descriptors") already converted most of the driver to use GPIO descriptors. > What is still missing is the platform specific hook gpio_blink_set() and > board files

[PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-10-31 Thread Mika Westerberg
Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO descriptors") already converted most of the driver to use GPIO descriptors. What is still missing is the platform specific hook gpio_blink_set() and board files which pass legacy GPIO numbers to this driver in platform data. In this

[PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-10-31 Thread Mika Westerberg
Commit 21f2aae91e902aad (leds: leds-gpio: Add support for GPIO descriptors) already converted most of the driver to use GPIO descriptors. What is still missing is the platform specific hook gpio_blink_set() and board files which pass legacy GPIO numbers to this driver in platform data. In this

Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors

2014-10-31 Thread Andrew Lunn
On Fri, Oct 31, 2014 at 01:40:58PM +0200, Mika Westerberg wrote: Commit 21f2aae91e902aad (leds: leds-gpio: Add support for GPIO descriptors) already converted most of the driver to use GPIO descriptors. What is still missing is the platform specific hook gpio_blink_set() and board files which