Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-08 Thread Takashi Iwai
On Tue, 08 Sep 2015 10:25:31 +0200, Kim, Milo wrote: > > > The fallback to user helper mode is bad for the recent udev, since > > udev already dropped the f/w support code completely. Thus every > > non-existing f/w load will result in 60 seconds stall. > > However, timeout is changed to

Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-08 Thread Kim, Milo
Hi Takashi, On 9/8/2015 2:06 PM, Takashi Iwai wrote: On Tue, 08 Sep 2015 02:30:07 +0200, Kim, Milo wrote: Hi Takashi, On 9/7/2015 11:19 PM, Jacek Anaszewski wrote: Hi Takashi, Thanks for chasing this. Milo, could you express your opinion? On 09/07/2015 02:25 PM, Takashi Iwai wrote: The

Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-08 Thread Jacek Anaszewski
On 09/08/2015 07:06 AM, Takashi Iwai wrote: On Tue, 08 Sep 2015 02:30:07 +0200, Kim, Milo wrote: Hi Takashi, On 9/7/2015 11:19 PM, Jacek Anaszewski wrote: Hi Takashi, Thanks for chasing this. Milo, could you express your opinion? On 09/07/2015 02:25 PM, Takashi Iwai wrote: The commit

Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-08 Thread Kim, Milo
Hi Takashi, On 9/8/2015 2:06 PM, Takashi Iwai wrote: On Tue, 08 Sep 2015 02:30:07 +0200, Kim, Milo wrote: Hi Takashi, On 9/7/2015 11:19 PM, Jacek Anaszewski wrote: Hi Takashi, Thanks for chasing this. Milo, could you express your opinion? On 09/07/2015 02:25 PM, Takashi Iwai wrote: The

Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-08 Thread Jacek Anaszewski
On 09/08/2015 07:06 AM, Takashi Iwai wrote: On Tue, 08 Sep 2015 02:30:07 +0200, Kim, Milo wrote: Hi Takashi, On 9/7/2015 11:19 PM, Jacek Anaszewski wrote: Hi Takashi, Thanks for chasing this. Milo, could you express your opinion? On 09/07/2015 02:25 PM, Takashi Iwai wrote: The commit

Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-08 Thread Takashi Iwai
On Tue, 08 Sep 2015 10:25:31 +0200, Kim, Milo wrote: > > > The fallback to user helper mode is bad for the recent udev, since > > udev already dropped the f/w support code completely. Thus every > > non-existing f/w load will result in 60 seconds stall. > > However, timeout is changed to

Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-07 Thread Takashi Iwai
On Tue, 08 Sep 2015 02:30:07 +0200, Kim, Milo wrote: > > Hi Takashi, > > On 9/7/2015 11:19 PM, Jacek Anaszewski wrote: > > Hi Takashi, > > > > Thanks for chasing this. > > Milo, could you express your opinion? > > > > On 09/07/2015 02:25 PM, Takashi Iwai wrote: > >> The commit [b67893206fc0:

Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-07 Thread Kim, Milo
Hi Takashi, On 9/7/2015 11:19 PM, Jacek Anaszewski wrote: Hi Takashi, Thanks for chasing this. Milo, could you express your opinion? On 09/07/2015 02:25 PM, Takashi Iwai wrote: The commit [b67893206fc0: leds:lp55xx: fix firmware loading error] tries to address the firmware file handling with

Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-07 Thread Jacek Anaszewski
Hi Takashi, Thanks for chasing this. Milo, could you express your opinion? On 09/07/2015 02:25 PM, Takashi Iwai wrote: The commit [b67893206fc0: leds:lp55xx: fix firmware loading error] tries to address the firmware file handling with user helper, but it sets a wrong Kconfig

[PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-07 Thread Takashi Iwai
The commit [b67893206fc0: leds:lp55xx: fix firmware loading error] tries to address the firmware file handling with user helper, but it sets a wrong Kconfig CONFIG_FW_LOADER_USER_HELPER_FALLBACK. Since the wrong option was enabled, the system got a regression -- it suffers from the unexpected

[PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-07 Thread Takashi Iwai
The commit [b67893206fc0: leds:lp55xx: fix firmware loading error] tries to address the firmware file handling with user helper, but it sets a wrong Kconfig CONFIG_FW_LOADER_USER_HELPER_FALLBACK. Since the wrong option was enabled, the system got a regression -- it suffers from the unexpected

Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-07 Thread Jacek Anaszewski
Hi Takashi, Thanks for chasing this. Milo, could you express your opinion? On 09/07/2015 02:25 PM, Takashi Iwai wrote: The commit [b67893206fc0: leds:lp55xx: fix firmware loading error] tries to address the firmware file handling with user helper, but it sets a wrong Kconfig

Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-07 Thread Kim, Milo
Hi Takashi, On 9/7/2015 11:19 PM, Jacek Anaszewski wrote: Hi Takashi, Thanks for chasing this. Milo, could you express your opinion? On 09/07/2015 02:25 PM, Takashi Iwai wrote: The commit [b67893206fc0: leds:lp55xx: fix firmware loading error] tries to address the firmware file handling with

Re: [PATCH] leds:lp55xx: Correct Kconfig dependency for f/w user helper

2015-09-07 Thread Takashi Iwai
On Tue, 08 Sep 2015 02:30:07 +0200, Kim, Milo wrote: > > Hi Takashi, > > On 9/7/2015 11:19 PM, Jacek Anaszewski wrote: > > Hi Takashi, > > > > Thanks for chasing this. > > Milo, could you express your opinion? > > > > On 09/07/2015 02:25 PM, Takashi Iwai wrote: > >> The commit [b67893206fc0: