Re: [PATCH] lib/kobject: fix memory leak in error path of kset_create_and_add()

Nicolai Stange writes: > Greg Kroah-Hartman writes: > >> On Tue, Nov 17, 2015 at 01:04:19AM +0100, Nicolai Stange wrote: >>> +} >>> + >>> +static struct kobj_type glue_dirs_ktype = { >>> + .release = glue_dirs_release_dummy, >>> +}; >>> + >>> /* Hotplug events for classes go to the class

Re: [PATCH] lib/kobject: fix memory leak in error path of kset_create_and_add()

Greg Kroah-Hartman writes: > On Tue, Nov 17, 2015 at 01:04:19AM +0100, Nicolai Stange wrote: >> Similar problems exist at all call sites of kset_register(), that is >> in drivers/base, fs/ext4 and in fs/ocfs2. > > Yes, but those calls all succeed, so this isn't a problem in the "real" > world :)

Re: [PATCH] lib/kobject: fix memory leak in error path of kset_create_and_add()

Nicolai Stange writes: > Greg Kroah-Hartman writes: > >> On Tue, Nov 17, 2015 at 01:04:19AM +0100, Nicolai Stange wrote: >>> +} >>> + >>> +static struct kobj_type glue_dirs_ktype = { >>> + .release = glue_dirs_release_dummy, >>> +}; >>> + >>>

Re: [PATCH] lib/kobject: fix memory leak in error path of kset_create_and_add()

Greg Kroah-Hartman writes: > On Tue, Nov 17, 2015 at 01:04:19AM +0100, Nicolai Stange wrote: >> Similar problems exist at all call sites of kset_register(), that is >> in drivers/base, fs/ext4 and in fs/ocfs2. > > Yes, but those calls all succeed, so this isn't a

Re: [PATCH] lib/kobject: fix memory leak in error path of kset_create_and_add()

On Tue, Nov 17, 2015 at 01:04:19AM +0100, Nicolai Stange wrote: > In kset_create_and_add(), the name duped into the kset's kobject by > kset_create() gets leaked if the call to kset_register() fails. > > Indeed, triggering failure by invoking kset_create_and_add() with a > duplicate name makes

[PATCH] lib/kobject: fix memory leak in error path of kset_create_and_add()

In kset_create_and_add(), the name duped into the kset's kobject by kset_create() gets leaked if the call to kset_register() fails. Indeed, triggering failure by invoking kset_create_and_add() with a duplicate name makes kmemleak reporting unreferenced object 0x8800b4a1f428 (size 16):

[PATCH] lib/kobject: fix memory leak in error path of kset_create_and_add()

In kset_create_and_add(), the name duped into the kset's kobject by kset_create() gets leaked if the call to kset_register() fails. Indeed, triggering failure by invoking kset_create_and_add() with a duplicate name makes kmemleak reporting unreferenced object 0x8800b4a1f428 (size 16):

Re: [PATCH] lib/kobject: fix memory leak in error path of kset_create_and_add()

On Tue, Nov 17, 2015 at 01:04:19AM +0100, Nicolai Stange wrote: > In kset_create_and_add(), the name duped into the kset's kobject by > kset_create() gets leaked if the call to kset_register() fails. > > Indeed, triggering failure by invoking kset_create_and_add() with a > duplicate name makes