Re: [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings

2018-02-14 Thread Anshuman Khandual
On 02/14/2018 09:33 PM, Bart Van Assche wrote: > On Wed, 2018-02-14 at 10:28 +0530, Anshuman Khandual wrote: >> +#define SG_CHAIN0x01 >> +#define SG_EMARK0x02 > > Hello Anshuman, > > As you probably know constants that do not have a suffix are of type int. > Please > consider to add suff

Re: [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings

2018-02-14 Thread Anshuman Khandual
On 02/14/2018 09:41 PM, Tvrtko Ursulin wrote: > > On 14/02/18 08:32, Johannes Thumshirn wrote: >> On Wed, 2018-02-14 at 10:28 +0530, Anshuman Khandual wrote: >>> This replaces scatterlist->page_link LSB encodings with SG_CHAIN and >>> SG_EMARK definitions without any functional change. >>> >>> Sig

Re: [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings

2018-02-14 Thread Tvrtko Ursulin
On 14/02/18 08:32, Johannes Thumshirn wrote: On Wed, 2018-02-14 at 10:28 +0530, Anshuman Khandual wrote: This replaces scatterlist->page_link LSB encodings with SG_CHAIN and SG_EMARK definitions without any functional change. Signed-off-by: Anshuman Khandual ---  include/linux/scatterlist.h

Re: [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings

2018-02-14 Thread Bart Van Assche
On Wed, 2018-02-14 at 10:28 +0530, Anshuman Khandual wrote: > +#define SG_CHAIN 0x01 > +#define SG_EMARK 0x02 Hello Anshuman, As you probably know constants that do not have a suffix are of type int. Please consider to add suffix "UL" to these constants to avoid that the compiler could ta

Re: [PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings

2018-02-14 Thread Johannes Thumshirn
On Wed, 2018-02-14 at 10:28 +0530, Anshuman Khandual wrote: > This replaces scatterlist->page_link LSB encodings with SG_CHAIN and > SG_EMARK definitions without any functional change. > > Signed-off-by: Anshuman Khandual > --- >  include/linux/scatterlist.h | 23 +-- >  1 file

[PATCH] lib/scatterlist: Add SG_CHAIN and SG_EMARK macros for LSB encodings

2018-02-13 Thread Anshuman Khandual
This replaces scatterlist->page_link LSB encodings with SG_CHAIN and SG_EMARK definitions without any functional change. Signed-off-by: Anshuman Khandual --- include/linux/scatterlist.h | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/include/linux/sc