Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-09 Thread Cong Wang
On Thu, Dec 7, 2017 at 11:54 PM, Jason Yan wrote: > > We have sent a patchset to fix this and to enhance libsas hotplug. > Please refer to https://lkml.org/lkml/2017/9/6/142 > > And I'm going to send a new version soon. Thanks for working on it! Please make sure they will be

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-09 Thread Cong Wang
On Thu, Dec 7, 2017 at 11:54 PM, Jason Yan wrote: > > We have sent a patchset to fix this and to enhance libsas hotplug. > Please refer to https://lkml.org/lkml/2017/9/6/142 > > And I'm going to send a new version soon. Thanks for working on it! Please make sure they will be queued for -stable

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-07 Thread Jason Yan
On 2017/12/8 6:57, Cong Wang wrote: On Thu, Dec 7, 2017 at 5:37 AM, John Garry wrote: On 28/11/2017 17:04, Cong Wang wrote: I don't understand, the only caller of sas_unregister_domain_devices() is sas_deform_port(). And sas_deform_port() may be called from another

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-07 Thread Jason Yan
On 2017/12/8 6:57, Cong Wang wrote: On Thu, Dec 7, 2017 at 5:37 AM, John Garry wrote: On 28/11/2017 17:04, Cong Wang wrote: I don't understand, the only caller of sas_unregister_domain_devices() is sas_deform_port(). And sas_deform_port() may be called from another worker on the same

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-07 Thread Cong Wang
On Thu, Dec 7, 2017 at 4:40 PM, Cong Wang wrote: > On Thu, Dec 7, 2017 at 2:57 PM, Cong Wang wrote: >> On Thu, Dec 7, 2017 at 5:37 AM, John Garry wrote: >>> On 28/11/2017 17:04, Cong Wang wrote: I don't

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-07 Thread Cong Wang
On Thu, Dec 7, 2017 at 4:40 PM, Cong Wang wrote: > On Thu, Dec 7, 2017 at 2:57 PM, Cong Wang wrote: >> On Thu, Dec 7, 2017 at 5:37 AM, John Garry wrote: >>> On 28/11/2017 17:04, Cong Wang wrote: I don't understand, the only caller of sas_unregister_domain_devices() is

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-07 Thread Cong Wang
On Thu, Dec 7, 2017 at 2:57 PM, Cong Wang wrote: > On Thu, Dec 7, 2017 at 5:37 AM, John Garry wrote: >> On 28/11/2017 17:04, Cong Wang wrote: >>> >>> I don't understand, the only caller of sas_unregister_domain_devices() >>> is sas_deform_port().

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-07 Thread Cong Wang
On Thu, Dec 7, 2017 at 2:57 PM, Cong Wang wrote: > On Thu, Dec 7, 2017 at 5:37 AM, John Garry wrote: >> On 28/11/2017 17:04, Cong Wang wrote: >>> >>> I don't understand, the only caller of sas_unregister_domain_devices() >>> is sas_deform_port(). >>> >> >> And sas_deform_port() may be called

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-07 Thread Cong Wang
On Thu, Dec 7, 2017 at 5:37 AM, John Garry wrote: > On 28/11/2017 17:04, Cong Wang wrote: >> >> I don't understand, the only caller of sas_unregister_domain_devices() >> is sas_deform_port(). >> > > And sas_deform_port() may be called from another worker on the same queue,

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-07 Thread Cong Wang
On Thu, Dec 7, 2017 at 5:37 AM, John Garry wrote: > On 28/11/2017 17:04, Cong Wang wrote: >> >> I don't understand, the only caller of sas_unregister_domain_devices() >> is sas_deform_port(). >> > > And sas_deform_port() may be called from another worker on the same queue, > right? As in

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-07 Thread John Garry
On 28/11/2017 17:04, Cong Wang wrote: On Tue, Nov 28, 2017 at 3:18 AM, John Garry wrote: On 28/11/2017 08:20, Johannes Thumshirn wrote: On Mon, Nov 27, 2017 at 04:24:45PM -0800, Cong Wang wrote: We saw dozens of the following kernel waring: WARNING: CPU: 0 PID: 705

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-12-07 Thread John Garry
On 28/11/2017 17:04, Cong Wang wrote: On Tue, Nov 28, 2017 at 3:18 AM, John Garry wrote: On 28/11/2017 08:20, Johannes Thumshirn wrote: On Mon, Nov 27, 2017 at 04:24:45PM -0800, Cong Wang wrote: We saw dozens of the following kernel waring: WARNING: CPU: 0 PID: 705 at

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-11-28 Thread Cong Wang
On Tue, Nov 28, 2017 at 3:18 AM, John Garry wrote: > On 28/11/2017 08:20, Johannes Thumshirn wrote: >> >> On Mon, Nov 27, 2017 at 04:24:45PM -0800, Cong Wang wrote: >>> >>> We saw dozens of the following kernel waring: >>> >>> WARNING: CPU: 0 PID: 705 at

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-11-28 Thread Cong Wang
On Tue, Nov 28, 2017 at 3:18 AM, John Garry wrote: > On 28/11/2017 08:20, Johannes Thumshirn wrote: >> >> On Mon, Nov 27, 2017 at 04:24:45PM -0800, Cong Wang wrote: >>> >>> We saw dozens of the following kernel waring: >>> >>> WARNING: CPU: 0 PID: 705 at fs/sysfs/group.c:224 >>>

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-11-28 Thread Cong Wang
On Tue, Nov 28, 2017 at 12:20 AM, Johannes Thumshirn wrote: > On Mon, Nov 27, 2017 at 04:24:45PM -0800, Cong Wang wrote: >> We saw dozens of the following kernel waring: >> >> WARNING: CPU: 0 PID: 705 at fs/sysfs/group.c:224 >> sysfs_remove_group+0x54/0x88() >> sysfs group

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-11-28 Thread Cong Wang
On Tue, Nov 28, 2017 at 12:20 AM, Johannes Thumshirn wrote: > On Mon, Nov 27, 2017 at 04:24:45PM -0800, Cong Wang wrote: >> We saw dozens of the following kernel waring: >> >> WARNING: CPU: 0 PID: 705 at fs/sysfs/group.c:224 >> sysfs_remove_group+0x54/0x88() >> sysfs group 81ab7670 not

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-11-28 Thread John Garry
On 28/11/2017 08:20, Johannes Thumshirn wrote: On Mon, Nov 27, 2017 at 04:24:45PM -0800, Cong Wang wrote: We saw dozens of the following kernel waring: WARNING: CPU: 0 PID: 705 at fs/sysfs/group.c:224 sysfs_remove_group+0x54/0x88() sysfs group 81ab7670 not found for kobject '6:0:3:0'

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-11-28 Thread John Garry
On 28/11/2017 08:20, Johannes Thumshirn wrote: On Mon, Nov 27, 2017 at 04:24:45PM -0800, Cong Wang wrote: We saw dozens of the following kernel waring: WARNING: CPU: 0 PID: 705 at fs/sysfs/group.c:224 sysfs_remove_group+0x54/0x88() sysfs group 81ab7670 not found for kobject '6:0:3:0'

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-11-28 Thread Johannes Thumshirn
On Mon, Nov 27, 2017 at 04:24:45PM -0800, Cong Wang wrote: > We saw dozens of the following kernel waring: > > WARNING: CPU: 0 PID: 705 at fs/sysfs/group.c:224 > sysfs_remove_group+0x54/0x88() > sysfs group 81ab7670 not found for kobject '6:0:3:0' > Modules linked in: cpufreq_ondemand

Re: [PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-11-28 Thread Johannes Thumshirn
On Mon, Nov 27, 2017 at 04:24:45PM -0800, Cong Wang wrote: > We saw dozens of the following kernel waring: > > WARNING: CPU: 0 PID: 705 at fs/sysfs/group.c:224 > sysfs_remove_group+0x54/0x88() > sysfs group 81ab7670 not found for kobject '6:0:3:0' > Modules linked in: cpufreq_ondemand

[PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-11-27 Thread Cong Wang
We saw dozens of the following kernel waring: WARNING: CPU: 0 PID: 705 at fs/sysfs/group.c:224 sysfs_remove_group+0x54/0x88() sysfs group 81ab7670 not found for kobject '6:0:3:0' Modules linked in: cpufreq_ondemand x86_pkg_temp_thermal coretemp kvm_intel kvm microcode raid0 iTCO_wdt

[PATCH] libsas: flush pending destruct work in sas_unregister_domain_devices()

2017-11-27 Thread Cong Wang
We saw dozens of the following kernel waring: WARNING: CPU: 0 PID: 705 at fs/sysfs/group.c:224 sysfs_remove_group+0x54/0x88() sysfs group 81ab7670 not found for kobject '6:0:3:0' Modules linked in: cpufreq_ondemand x86_pkg_temp_thermal coretemp kvm_intel kvm microcode raid0 iTCO_wdt