Re: [PATCH] lightnvm: fix memory leak when submit fails

2021-01-21 Thread Heiner Litz
thanks, Matias, I am going to look out for dm-zap! On Thu, Jan 21, 2021 at 12:14 PM Matias Bjørling wrote: > > On 21/01/2021 20.49, Heiner Litz wrote: > > there are a couple more, but again I would understand if those are > > deemed not important enough to keep it. > > > > device emulation of

Re: [PATCH] lightnvm: fix memory leak when submit fails

2021-01-21 Thread Matias Bjørling
On 21/01/2021 20.49, Heiner Litz wrote: there are a couple more, but again I would understand if those are deemed not important enough to keep it. device emulation of (non-ZNS) SSD block device That'll soon be available. We will be open-sourcing a new device mapper (dm-zap), which implements

Re: [PATCH] lightnvm: fix memory leak when submit fails

2021-01-21 Thread Heiner Litz
there are a couple more, but again I would understand if those are deemed not important enough to keep it. device emulation of (non-ZNS) SSD block device die control: yes endurance groups would help but I am not aware of any vendor supporting it finer-grained control: 1000's of open blocks vs. a

Re: [PATCH] lightnvm: fix memory leak when submit fails

2021-01-21 Thread Matias Bjørling
On 21/01/2021 17.58, Heiner Litz wrote: I don't think that ZNS supersedes OCSSD. OCSSDs provide much more flexibility and device control and remain valuable for academia. For us, PBLK is the most accurate "SSD Emulator" out there that, as another benefit, enables real-time performance

Re: [PATCH] lightnvm: fix memory leak when submit fails

2021-01-21 Thread Heiner Litz
I don't think that ZNS supersedes OCSSD. OCSSDs provide much more flexibility and device control and remain valuable for academia. For us, PBLK is the most accurate "SSD Emulator" out there that, as another benefit, enables real-time performance measurements. That being said, I understand that

Re: [PATCH] lightnvm: fix memory leak when submit fails

2021-01-21 Thread Matias Bjørling
On 21/01/2021 13.47, Jens Axboe wrote: On 1/21/21 12:22 AM, Pan Bian wrote: The allocated page is not released if error occurs in nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid possible memory leak issue. Applied, thanks. General question for Matias - is lightnvm maintained

Re: [PATCH] lightnvm: fix memory leak when submit fails

2021-01-21 Thread Javier González
On 21.01.2021 05:47, Jens Axboe wrote: On 1/21/21 12:22 AM, Pan Bian wrote: The allocated page is not released if error occurs in nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid possible memory leak issue. Applied, thanks. General question for Matias - is lightnvm maintained

[PATCH] lightnvm: fix memory leak when submit fails

2021-01-21 Thread Pan Bian
The allocated page is not released if error occurs in nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid possible memory leak issue. Fixes: aff3fb18f957 ("lightnvm: move bad block and chunk state logic to core") Signed-off-by: Pan Bian --- drivers/lightnvm/core.c | 3 +-- 1 file

Re: [PATCH] lightnvm: fix memory leak when submit fails

2021-01-21 Thread Jens Axboe
On 1/21/21 12:22 AM, Pan Bian wrote: > The allocated page is not released if error occurs in > nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid > possible memory leak issue. Applied, thanks. General question for Matias - is lightnvm maintained anymore at all, or should we remove