Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, Dec 19, 2017 at 12:11:24PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 18:07:16 +0100 > Peter Zijlstra wrote: > > > On Tue, Dec 19, 2017 at 11:52:38AM -0500, Steven Rostedt wrote: > > > Then I suggest that you can either take my patch to improve the > > >

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, Dec 19, 2017 at 12:11:24PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 18:07:16 +0100 > Peter Zijlstra wrote: > > > On Tue, Dec 19, 2017 at 11:52:38AM -0500, Steven Rostedt wrote: > > > Then I suggest that you can either take my patch to improve the > > > visual or remove the

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, 19 Dec 2017 18:07:16 +0100 Peter Zijlstra wrote: > On Tue, Dec 19, 2017 at 11:52:38AM -0500, Steven Rostedt wrote: > > Then I suggest that you can either take my patch to improve the > > visual or remove the visual completely, as nobody cares about it. > >

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, 19 Dec 2017 18:07:16 +0100 Peter Zijlstra wrote: > On Tue, Dec 19, 2017 at 11:52:38AM -0500, Steven Rostedt wrote: > > Then I suggest that you can either take my patch to improve the > > visual or remove the visual completely, as nobody cares about it. > > Doesn't apply as is; but can

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, 19 Dec 2017 11:54:10 -0500 Dhaval Giani wrote: > On 2017-12-19 11:52 AM, Steven Rostedt wrote: > > On Tue, 19 Dec 2017 17:46:19 +0100 > > Peter Zijlstra wrote: > > > > > >> It really isn't that hard, Its mostly a question of TL;DR. > >>

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, 19 Dec 2017 11:54:10 -0500 Dhaval Giani wrote: > On 2017-12-19 11:52 AM, Steven Rostedt wrote: > > On Tue, 19 Dec 2017 17:46:19 +0100 > > Peter Zijlstra wrote: > > > > > >> It really isn't that hard, Its mostly a question of TL;DR. > >> > >> #0 is useless and should be thrown out >

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, Dec 19, 2017 at 11:52:38AM -0500, Steven Rostedt wrote: > Then I suggest that you can either take my patch to improve the > visual or remove the visual completely, as nobody cares about it. Doesn't apply as is; but can you at least make it shut up if the chain is longer than you support?

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, Dec 19, 2017 at 11:52:38AM -0500, Steven Rostedt wrote: > Then I suggest that you can either take my patch to improve the > visual or remove the visual completely, as nobody cares about it. Doesn't apply as is; but can you at least make it shut up if the chain is longer than you support?

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On 2017-12-19 11:52 AM, Steven Rostedt wrote: > On Tue, 19 Dec 2017 17:46:19 +0100 > Peter Zijlstra wrote: > > >> It really isn't that hard, Its mostly a question of TL;DR. >> >> #0 is useless and should be thrown out >> #1 shows where we take #1 while holding #0 >> .. >>

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On 2017-12-19 11:52 AM, Steven Rostedt wrote: > On Tue, 19 Dec 2017 17:46:19 +0100 > Peter Zijlstra wrote: > > >> It really isn't that hard, Its mostly a question of TL;DR. >> >> #0 is useless and should be thrown out >> #1 shows where we take #1 while holding #0 >> .. >> #n shows where we take

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, 19 Dec 2017 17:46:19 +0100 Peter Zijlstra wrote: > It really isn't that hard, Its mostly a question of TL;DR. > > #0 is useless and should be thrown out > #1 shows where we take #1 while holding #0 > .. > #n shows where we take #n while holding #n-1 > > And the

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, 19 Dec 2017 17:46:19 +0100 Peter Zijlstra wrote: > It really isn't that hard, Its mostly a question of TL;DR. > > #0 is useless and should be thrown out > #1 shows where we take #1 while holding #0 > .. > #n shows where we take #n while holding #n-1 > > And the bottom callstack shows

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, Dec 19, 2017 at 11:30:29AM -0500, Dhaval Giani wrote: > On 2017-12-14 12:59 PM, Peter Zijlstra wrote: > > On Thu, Dec 14, 2017 at 12:38:52PM -0500, Steven Rostedt wrote: > >> > >> Currently, when lockdep detects a possible deadlock scenario that involves > >> 3 > >> or more levels, it

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Tue, Dec 19, 2017 at 11:30:29AM -0500, Dhaval Giani wrote: > On 2017-12-14 12:59 PM, Peter Zijlstra wrote: > > On Thu, Dec 14, 2017 at 12:38:52PM -0500, Steven Rostedt wrote: > >> > >> Currently, when lockdep detects a possible deadlock scenario that involves > >> 3 > >> or more levels, it

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On 2017-12-14 12:59 PM, Peter Zijlstra wrote: > On Thu, Dec 14, 2017 at 12:38:52PM -0500, Steven Rostedt wrote: >> >> Currently, when lockdep detects a possible deadlock scenario that involves 3 >> or more levels, it just shows the chain, and a CPU sequence order of the >> first and last part of

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On 2017-12-14 12:59 PM, Peter Zijlstra wrote: > On Thu, Dec 14, 2017 at 12:38:52PM -0500, Steven Rostedt wrote: >> >> Currently, when lockdep detects a possible deadlock scenario that involves 3 >> or more levels, it just shows the chain, and a CPU sequence order of the >> first and last part of

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Thu, 14 Dec 2017 18:59:31 +0100 Peter Zijlstra wrote: > On Thu, Dec 14, 2017 at 12:38:52PM -0500, Steven Rostedt wrote: > > > > Currently, when lockdep detects a possible deadlock scenario that involves 3 > > or more levels, it just shows the chain, and a CPU sequence

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Thu, 14 Dec 2017 18:59:31 +0100 Peter Zijlstra wrote: > On Thu, Dec 14, 2017 at 12:38:52PM -0500, Steven Rostedt wrote: > > > > Currently, when lockdep detects a possible deadlock scenario that involves 3 > > or more levels, it just shows the chain, and a CPU sequence order of the > > first

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Thu, Dec 14, 2017 at 12:38:52PM -0500, Steven Rostedt wrote: > > Currently, when lockdep detects a possible deadlock scenario that involves 3 > or more levels, it just shows the chain, and a CPU sequence order of the > first and last part of the scenario, leaving out the middle level and this

Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario

On Thu, Dec 14, 2017 at 12:38:52PM -0500, Steven Rostedt wrote: > > Currently, when lockdep detects a possible deadlock scenario that involves 3 > or more levels, it just shows the chain, and a CPU sequence order of the > first and last part of the scenario, leaving out the middle level and this

[PATCH] lockdep: Show up to three levels for a deadlock scenario

Currently, when lockdep detects a possible deadlock scenario that involves 3 or more levels, it just shows the chain, and a CPU sequence order of the first and last part of the scenario, leaving out the middle level and this can take a bit of effort to understand. By adding a third level, it

[PATCH] lockdep: Show up to three levels for a deadlock scenario

Currently, when lockdep detects a possible deadlock scenario that involves 3 or more levels, it just shows the chain, and a CPU sequence order of the first and last part of the scenario, leaving out the middle level and this can take a bit of effort to understand. By adding a third level, it