Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

2014-07-04 Thread Geert Uytterhoeven
On Fri, Jul 4, 2014 at 6:10 PM, Nick Krause wrote: > Very well then seems I should resend this patch removing the define > line as it seems to have no use > in this file. Indeed. Thanks in advance! FYI, the last user of _KERNPG_TABLE was removed in 2.5.18. > Cheers Nick > > On Fri, Jul 4, 2014 a

Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

2014-07-04 Thread Nick Krause
Very well then seems I should resend this patch removing the define line as it seems to have no use in this file. Cheers Nick On Fri, Jul 4, 2014 at 2:19 AM, Finn Thain wrote: > > On Fri, 4 Jul 2014, Nick Krause wrote: > >> What are these two lines for them another compile issue? > > I don't see

Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

2014-07-03 Thread Finn Thain
On Fri, 4 Jul 2014, Nick Krause wrote: > What are these two lines for them another compile issue? I don't see why those two lines are important. > >> -/* FIXME - when we get this compiling */ > >> /* erm, now that it's compiling, what do we do with it? */ > >> #define _KERNPG_TABLE 0 Presuma

Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

2014-07-03 Thread Nick Krause
-/* FIXME - when we get this compiling */ > /* erm, now that it's compiling, what do we do with it? */ What are these two lines for them another compile issue? Cheers Nick On Thu, Jul 3, 2014 at 9:28 PM, Finn Thain wrote: > > On Wed, 2 Jul 2014, Nicholas Krause wrote: > >> Removes a FIXME commen

Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

2014-07-03 Thread Finn Thain
On Wed, 2 Jul 2014, Nicholas Krause wrote: > Removes a FIXME comment in this file due to it not compiling as it now > compiles. What got fixed? It doesn't say "FIXME - this doesn't compile". > > Signed-off-by: Nicholas Krause > --- > arch/m68k/include/asm/sun3_pgalloc.h | 1 - > 1 file cha

Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

2014-07-03 Thread Sam Creasey
Acked-by: Sam Creasey On Wed, Jul 02, 2014 at 09:41:33PM -0400, Nicholas Krause wrote: > Removes a FIXME comment in this file due to it not compiling > as it now compiles. > > Signed-off-by: Nicholas Krause > --- > arch/m68k/include/asm/sun3_pgalloc.h | 1 - > 1 file changed, 1 deletion(-)

[PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

2014-07-02 Thread Nicholas Krause
Removes a FIXME comment in this file due to it not compiling as it now compiles. Signed-off-by: Nicholas Krause --- arch/m68k/include/asm/sun3_pgalloc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h index f868506..