[PATCH] media: em28xx: Fix exception handling in em28xx_alloc_urbs()

[Markus Elfring]

From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 26 Aug 2019 13:14:02 +0200

A null pointer would be passed to a call of the function "kfree" directly
after a call of the function "kcalloc" failed at one place.
Pass the data structure member "urb" instead for which memory
was allocated before (so that this resource will be properly cleaned up).

This issue was detected by using the Coccinelle software.

Fixes: d571b592c6206d33731f41aa710fa0f69ac8611b ("media: em28xx: don't use 
coherent buffer for DMA transfers")
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/media/usb/em28xx/em28xx-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/em28xx/em28xx-core.c 
b/drivers/media/usb/em28xx/em28xx-core.c
index 2b8c84a5c9a8..e6088b5d1b80 100644
--- a/drivers/media/usb/em28xx/em28xx-core.c
+++ b/drivers/media/usb/em28xx/em28xx-core.c
@@ -931,7 +931,7 @@ int em28xx_alloc_urbs(struct em28xx *dev, enum em28xx_mode 
mode, int xfer_bulk,

        usb_bufs->buf = kcalloc(num_bufs, sizeof(void *), GFP_KERNEL);
        if (!usb_bufs->buf) {
-               kfree(usb_bufs->buf);
+               kfree(usb_bufs->urb);
                return -ENOMEM;
        }

--
2.23.0