Re: [PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len()

2014-03-22 Thread Shuah Khan
On 03/22/2014 11:40 AM, Frank Schäfer wrote: I'm more concerned about the fact that readers of the code could think that this is a write with a variable length, while the length is actually always the same. Fair enough. em28xx_reg_len() is a somewhat dirty hack for vidioc_[g,s]_register

Re: [PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len()

2014-03-22 Thread Frank Schäfer
Am 22.03.2014 16:22, schrieb Shuah Khan: > On 03/22/2014 06:32 AM, Frank Schäfer wrote: >> >> Am 21.03.2014 22:04, schrieb Shuah Khan: >>> Change em28xx_scaler_set() to use em28xx_reg_len() to get register >>> lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers, >>> instead of

Re: [PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len()

2014-03-22 Thread Shuah Khan
On 03/22/2014 06:32 AM, Frank Schäfer wrote: Am 21.03.2014 22:04, schrieb Shuah Khan: Change em28xx_scaler_set() to use em28xx_reg_len() to get register lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers, instead of hard-coding the length. Moved em28xx_reg_len() definition for

Re: [PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len()

2014-03-22 Thread Frank Schäfer
Am 21.03.2014 22:04, schrieb Shuah Khan: > Change em28xx_scaler_set() to use em28xx_reg_len() to get register > lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers, > instead of hard-coding the length. Moved em28xx_reg_len() definition > for it to be visible to

Re: [PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len()

2014-03-22 Thread Frank Schäfer
Am 21.03.2014 22:04, schrieb Shuah Khan: Change em28xx_scaler_set() to use em28xx_reg_len() to get register lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers, instead of hard-coding the length. Moved em28xx_reg_len() definition for it to be visible to em28xx_scaler_set().

Re: [PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len()

2014-03-22 Thread Shuah Khan
On 03/22/2014 06:32 AM, Frank Schäfer wrote: Am 21.03.2014 22:04, schrieb Shuah Khan: Change em28xx_scaler_set() to use em28xx_reg_len() to get register lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers, instead of hard-coding the length. Moved em28xx_reg_len() definition for

Re: [PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len()

2014-03-22 Thread Frank Schäfer
Am 22.03.2014 16:22, schrieb Shuah Khan: On 03/22/2014 06:32 AM, Frank Schäfer wrote: Am 21.03.2014 22:04, schrieb Shuah Khan: Change em28xx_scaler_set() to use em28xx_reg_len() to get register lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers, instead of hard-coding the

Re: [PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len()

2014-03-22 Thread Shuah Khan
On 03/22/2014 11:40 AM, Frank Schäfer wrote: I'm more concerned about the fact that readers of the code could think that this is a write with a variable length, while the length is actually always the same. Fair enough. em28xx_reg_len() is a somewhat dirty hack for vidioc_[g,s]_register

[PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len()

2014-03-21 Thread Shuah Khan
Change em28xx_scaler_set() to use em28xx_reg_len() to get register lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers, instead of hard-coding the length. Moved em28xx_reg_len() definition for it to be visible to em28xx_scaler_set(). Signed-off-by: Shuah Khan ---

[PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len()

2014-03-21 Thread Shuah Khan
Change em28xx_scaler_set() to use em28xx_reg_len() to get register lengths for EM28XX_R30_HSCALELOW and EM28XX_R32_VSCALELOW registers, instead of hard-coding the length. Moved em28xx_reg_len() definition for it to be visible to em28xx_scaler_set(). Signed-off-by: Shuah Khan shuah...@samsung.com