Re: [PATCH] media: staging: greybus: Release memory obtained by kasprintf

2017-09-21 Thread Rui Miguel Silva
Hi, On Thu, Sep 21, 2017 at 03:59:18PM +0300, Dan Carpenter wrote: > On Thu, Sep 21, 2017 at 05:05:27PM +0530, Arvind Yadav wrote: > > Free memory region, if gb_lights_channel_config is not successful. Arvind, thanks for patch and good catch. But please look at the subject of other patches

Re: [PATCH] media: staging: greybus: Release memory obtained by kasprintf

2017-09-21 Thread Rui Miguel Silva
Hi, On Thu, Sep 21, 2017 at 03:59:18PM +0300, Dan Carpenter wrote: > On Thu, Sep 21, 2017 at 05:05:27PM +0530, Arvind Yadav wrote: > > Free memory region, if gb_lights_channel_config is not successful. Arvind, thanks for patch and good catch. But please look at the subject of other patches

Re: [PATCH] media: staging: greybus: Release memory obtained by kasprintf

2017-09-21 Thread Dan Carpenter
On Thu, Sep 21, 2017 at 05:05:27PM +0530, Arvind Yadav wrote: > Free memory region, if gb_lights_channel_config is not successful. > The question I have is do we free this on module unload? I don't see that we do. I feel like we should do a free after calling __gb_lights_led_unregister(). But

Re: [PATCH] media: staging: greybus: Release memory obtained by kasprintf

2017-09-21 Thread Dan Carpenter
On Thu, Sep 21, 2017 at 05:05:27PM +0530, Arvind Yadav wrote: > Free memory region, if gb_lights_channel_config is not successful. > The question I have is do we free this on module unload? I don't see that we do. I feel like we should do a free after calling __gb_lights_led_unregister(). But

[PATCH] media: staging: greybus: Release memory obtained by kasprintf

2017-09-21 Thread Arvind Yadav
Free memory region, if gb_lights_channel_config is not successful. Signed-off-by: Arvind Yadav --- drivers/staging/greybus/light.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/light.c

[PATCH] media: staging: greybus: Release memory obtained by kasprintf

2017-09-21 Thread Arvind Yadav
Free memory region, if gb_lights_channel_config is not successful. Signed-off-by: Arvind Yadav --- drivers/staging/greybus/light.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index