Re: [PATCH] media: tw9910: add missed clk_disable_unprepare() on failure path

2018-12-30 Thread Alexey Khoroshilov
Hi Jacopo, On 30.12.2018 12:49, Jacopo Mondi wrote: > On Sun, Dec 30, 2018 at 12:35:20AM +0300, Alexey Khoroshilov wrote: >> If gpiod_get_optional() fails in tw9910_power_on(), clk is left undisabled. > > Correct, thanks for spotting this. > > I think pdn_gpio should also be handled if rstb_gpio

Re: [PATCH] media: tw9910: add missed clk_disable_unprepare() on failure path

2018-12-30 Thread Jacopo Mondi
Hi Alexey, thanks for the patch On Sun, Dec 30, 2018 at 12:35:20AM +0300, Alexey Khoroshilov wrote: > If gpiod_get_optional() fails in tw9910_power_on(), clk is left undisabled. > Correct, thanks for spotting this. I think pdn_gpio should also be handled if rstb_gpio fails. What's your opinio

[PATCH] media: tw9910: add missed clk_disable_unprepare() on failure path

2018-12-29 Thread Alexey Khoroshilov
If gpiod_get_optional() fails in tw9910_power_on(), clk is left undisabled. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/media/i2c/tw9910.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/tw9910.c b/drivers/me