Re: [PATCH] media: v4l2-ctrls: Add encoded frame quality controls

2020-05-22 Thread majja
Hi Hans, Thank you for the suggestion. I will update the patch accordingly. Regards, Maheshwar. On 2020-05-18 23:45, Hans Verkuil wrote: Hi Maheshwar, On 18/05/2020 23:09, ma...@codeaurora.org wrote: Hi, Regarding below patch - HEIF/HEIC image encoding uses HEVC/AVC encoders and clien

Re: [PATCH] media: v4l2-ctrls: Add encoded frame quality controls

2020-05-18 Thread Hans Verkuil
Hi Maheshwar, On 18/05/2020 23:09, ma...@codeaurora.org wrote: > Hi, > > Regarding below patch - > > HEIF/HEIC image encoding uses HEVC/AVC encoders and client can set image > quality level using > V4L2_CID_MPEG_VIDEO_FRAME_QUALITY control. > > Reference BITRATE_MODE_CQ at > https://developer.

Re: [PATCH] media: v4l2-ctrls: Add encoded frame quality controls

2020-05-18 Thread majja
Hi, Regarding below patch - HEIF/HEIC image encoding uses HEVC/AVC encoders and client can set image quality level using V4L2_CID_MPEG_VIDEO_FRAME_QUALITY control. Reference BITRATE_MODE_CQ at https://developer.android.com/reference/android/media/MediaCodecInfo.EncoderCapabilities#BITRATE_MOD

[PATCH] media: v4l2-ctrls: Add encoded frame quality controls

2020-05-18 Thread Maheshwar Ajja
When frame quality control is enabled encoder will choose the appropriate quantization parameter and bitrate to produce the client requested frame quality level. When frame quality control is disabled then frame quality is decided based on appropriate controls (i.e. V4L2_CID_MPEG_VIDEO_FRAME_RC_ENA