[PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-29 Thread qiuxishi
On 2012-8-22 16:37, Minchan Kim wrote: > Hi Jiang, > > On Wed, Aug 22, 2012 at 04:30:09PM +0800, Jiang Liu wrote: >> On 2012-8-22 16:14, Minchan Kim wrote: >>> On Wed, Aug 22, 2012 at 03:57:45PM +0800, qiuxishi wrote: On 2012-8-22 11:34, Minchan Kim wrote: > Hello Xishi, > > On

[PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-29 Thread qiuxishi
On 2012-8-22 16:37, Minchan Kim wrote: Hi Jiang, On Wed, Aug 22, 2012 at 04:30:09PM +0800, Jiang Liu wrote: On 2012-8-22 16:14, Minchan Kim wrote: On Wed, Aug 22, 2012 at 03:57:45PM +0800, qiuxishi wrote: On 2012-8-22 11:34, Minchan Kim wrote: Hello Xishi, On Tue, Aug 21, 2012 at

Re: [PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-22 Thread Minchan Kim
Hi Jiang, On Wed, Aug 22, 2012 at 04:30:09PM +0800, Jiang Liu wrote: > On 2012-8-22 16:14, Minchan Kim wrote: > > On Wed, Aug 22, 2012 at 03:57:45PM +0800, qiuxishi wrote: > >> On 2012-8-22 11:34, Minchan Kim wrote: > >>> Hello Xishi, > >>> > >>> On Tue, Aug 21, 2012 at 08:12:05PM +0800, qiuxishi

Re: [PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-22 Thread Jiang Liu
On 2012-8-22 16:14, Minchan Kim wrote: > On Wed, Aug 22, 2012 at 03:57:45PM +0800, qiuxishi wrote: >> On 2012-8-22 11:34, Minchan Kim wrote: >>> Hello Xishi, >>> >>> On Tue, Aug 21, 2012 at 08:12:05PM +0800, qiuxishi wrote: From: Xishi Qiu When offline a section, we move all the

Re: [PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-22 Thread Minchan Kim
On Wed, Aug 22, 2012 at 03:57:45PM +0800, qiuxishi wrote: > On 2012-8-22 11:34, Minchan Kim wrote: > > Hello Xishi, > > > > On Tue, Aug 21, 2012 at 08:12:05PM +0800, qiuxishi wrote: > >> From: Xishi Qiu > >> > >> When offline a section, we move all the free pages and pcp into > >>

Re: [PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-22 Thread qiuxishi
On 2012-8-22 11:34, Minchan Kim wrote: > Hello Xishi, > > On Tue, Aug 21, 2012 at 08:12:05PM +0800, qiuxishi wrote: >> From: Xishi Qiu >> >> When offline a section, we move all the free pages and pcp into >> MIGRATE_ISOLATE list first. >> start_isolate_page_range() >>

Re: [PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-22 Thread qiuxishi
On 2012-8-22 11:34, Minchan Kim wrote: Hello Xishi, On Tue, Aug 21, 2012 at 08:12:05PM +0800, qiuxishi wrote: From: Xishi Qiu qiuxi...@huawei.com When offline a section, we move all the free pages and pcp into MIGRATE_ISOLATE list first. start_isolate_page_range()

Re: [PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-22 Thread Minchan Kim
On Wed, Aug 22, 2012 at 03:57:45PM +0800, qiuxishi wrote: On 2012-8-22 11:34, Minchan Kim wrote: Hello Xishi, On Tue, Aug 21, 2012 at 08:12:05PM +0800, qiuxishi wrote: From: Xishi Qiu qiuxi...@huawei.com When offline a section, we move all the free pages and pcp into

Re: [PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-22 Thread Jiang Liu
On 2012-8-22 16:14, Minchan Kim wrote: On Wed, Aug 22, 2012 at 03:57:45PM +0800, qiuxishi wrote: On 2012-8-22 11:34, Minchan Kim wrote: Hello Xishi, On Tue, Aug 21, 2012 at 08:12:05PM +0800, qiuxishi wrote: From: Xishi Qiu qiuxi...@huawei.com When offline a section, we move all the free

Re: [PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-22 Thread Minchan Kim
Hi Jiang, On Wed, Aug 22, 2012 at 04:30:09PM +0800, Jiang Liu wrote: On 2012-8-22 16:14, Minchan Kim wrote: On Wed, Aug 22, 2012 at 03:57:45PM +0800, qiuxishi wrote: On 2012-8-22 11:34, Minchan Kim wrote: Hello Xishi, On Tue, Aug 21, 2012 at 08:12:05PM +0800, qiuxishi wrote: From:

Re: [PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-21 Thread Minchan Kim
Hello Xishi, On Tue, Aug 21, 2012 at 08:12:05PM +0800, qiuxishi wrote: > From: Xishi Qiu > > When offline a section, we move all the free pages and pcp into > MIGRATE_ISOLATE list first. > start_isolate_page_range() > set_migratetype_isolate() > drain_all_pages(), > > Here

[PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-21 Thread qiuxishi
From: Xishi Qiu When offline a section, we move all the free pages and pcp into MIGRATE_ISOLATE list first. start_isolate_page_range() set_migratetype_isolate() drain_all_pages(), Here is a problem, it is not sure that pcp will be moved into MIGRATE_ISOLATE list. They

Re: [PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-21 Thread Minchan Kim
Hello Xishi, On Tue, Aug 21, 2012 at 08:12:05PM +0800, qiuxishi wrote: From: Xishi Qiu qiuxi...@huawei.com When offline a section, we move all the free pages and pcp into MIGRATE_ISOLATE list first. start_isolate_page_range() set_migratetype_isolate()

[PATCH] memory-hotplug: fix a drain pcp bug when offline pages

2012-08-21 Thread qiuxishi
From: Xishi Qiu qiuxi...@huawei.com When offline a section, we move all the free pages and pcp into MIGRATE_ISOLATE list first. start_isolate_page_range() set_migratetype_isolate() drain_all_pages(), Here is a problem, it is not sure that pcp will be moved into