Re: [PATCH] mfd: db8500-prcmu: Provide sane error path values

2014-11-04 Thread Linus Walleij
On Mon, Nov 3, 2014 at 5:50 PM, Lee Jones wrote: > On Mon, 03 Nov 2014, Fabio Estevam wrote: > >> On Mon, Nov 3, 2014 at 2:15 PM, Lee Jones wrote: >> >> > /* Clean up the mailbox interrupts after pre-kernel code. */ >> > @@ -3179,15 +3179,14 @@ static int db8500_prcmu_probe(struct >> >

Re: [PATCH] mfd: db8500-prcmu: Provide sane error path values

2014-11-04 Thread Linus Walleij
On Mon, Nov 3, 2014 at 5:50 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 03 Nov 2014, Fabio Estevam wrote: On Mon, Nov 3, 2014 at 2:15 PM, Lee Jones lee.jo...@linaro.org wrote: /* Clean up the mailbox interrupts after pre-kernel code. */ @@ -3179,15 +3179,14 @@ static int

Re: [PATCH] mfd: db8500-prcmu: Provide sane error path values

2014-11-03 Thread Lee Jones
On Mon, 03 Nov 2014, Fabio Estevam wrote: > On Mon, Nov 3, 2014 at 2:15 PM, Lee Jones wrote: > > > /* Clean up the mailbox interrupts after pre-kernel code. */ > > @@ -3179,15 +3179,14 @@ static int db8500_prcmu_probe(struct > > platform_device *pdev) > > irq =

Re: [PATCH] mfd: db8500-prcmu: Provide sane error path values

2014-11-03 Thread Fabio Estevam
On Mon, Nov 3, 2014 at 2:15 PM, Lee Jones wrote: > /* Clean up the mailbox interrupts after pre-kernel code. */ > @@ -3179,15 +3179,14 @@ static int db8500_prcmu_probe(struct platform_device > *pdev) > irq = platform_get_irq(pdev, 0); > if (irq <= 0) { Shouldn't this be

[PATCH] mfd: db8500-prcmu: Provide sane error path values

2014-11-03 Thread Lee Jones
Also rid superfluous gotos and label. Cc: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/db8500-prcmu.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c index 89ae8bf..a820473 100644 ---

[PATCH] mfd: db8500-prcmu: Provide sane error path values

2014-11-03 Thread Lee Jones
Also rid superfluous gotos and label. Cc: Linus Walleij linus.wall...@linaro.org Signed-off-by: Lee Jones lee.jo...@linaro.org --- drivers/mfd/db8500-prcmu.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/mfd/db8500-prcmu.c

Re: [PATCH] mfd: db8500-prcmu: Provide sane error path values

2014-11-03 Thread Fabio Estevam
On Mon, Nov 3, 2014 at 2:15 PM, Lee Jones lee.jo...@linaro.org wrote: /* Clean up the mailbox interrupts after pre-kernel code. */ @@ -3179,15 +3179,14 @@ static int db8500_prcmu_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq = 0) {

Re: [PATCH] mfd: db8500-prcmu: Provide sane error path values

2014-11-03 Thread Lee Jones
On Mon, 03 Nov 2014, Fabio Estevam wrote: On Mon, Nov 3, 2014 at 2:15 PM, Lee Jones lee.jo...@linaro.org wrote: /* Clean up the mailbox interrupts after pre-kernel code. */ @@ -3179,15 +3179,14 @@ static int db8500_prcmu_probe(struct platform_device *pdev) irq =