Re: [PATCH] mfd: menelaus: remove null pointer dereference

2014-08-21 Thread Lee Jones
On Sat, 09 Aug 2014, Himangi Saraogi wrote: > If vtg is NULL, it is not possible to access its mode_reg field. At all > sites where the static function menelaus_set_voltage is called, the first > argument is the address of a structure defined in the file. So, the null > test is unnecessary and is

[PATCH] mfd: menelaus: remove null pointer dereference

2014-08-09 Thread Himangi Saraogi
If vtg is NULL, it is not possible to access its mode_reg field. At all sites where the static function menelaus_set_voltage is called, the first argument is the address of a structure defined in the file. So, the null test is unnecessary and is removed. Also, a label is done away with. This probl