Re: [PATCH] mfd: stw481x: Remove unused fields from struct stw481x

2015-03-17 Thread Lee Jones
On Tue, 17 Mar 2015, Axel Lin wrote: > 2015-02-16 19:51 GMT+08:00 Lee Jones : > > On Fri, 13 Feb 2015, Axel Lin wrote: > > > >> The mutex lock is not used at all, remove it. > >> The *vmmc_regulator is not necessary, use a local variable in > >> stw481x_vmmc_regulator_probe() instead. > >> > >>

Re: [PATCH] mfd: stw481x: Remove unused fields from struct stw481x

2015-03-17 Thread Lee Jones
On Tue, 17 Mar 2015, Axel Lin wrote: 2015-02-16 19:51 GMT+08:00 Lee Jones lee.jo...@linaro.org: On Fri, 13 Feb 2015, Axel Lin wrote: The mutex lock is not used at all, remove it. The *vmmc_regulator is not necessary, use a local variable in stw481x_vmmc_regulator_probe() instead.

Re: [PATCH] mfd: stw481x: Remove unused fields from struct stw481x

2015-03-16 Thread Axel Lin
2015-02-16 19:51 GMT+08:00 Lee Jones : > On Fri, 13 Feb 2015, Axel Lin wrote: > >> The mutex lock is not used at all, remove it. >> The *vmmc_regulator is not necessary, use a local variable in >> stw481x_vmmc_regulator_probe() instead. >> >> Signed-off-by: Axel Lin >> --- >>

Re: [PATCH] mfd: stw481x: Remove unused fields from struct stw481x

2015-03-16 Thread Axel Lin
2015-02-16 19:51 GMT+08:00 Lee Jones lee.jo...@linaro.org: On Fri, 13 Feb 2015, Axel Lin wrote: The mutex lock is not used at all, remove it. The *vmmc_regulator is not necessary, use a local variable in stw481x_vmmc_regulator_probe() instead. Signed-off-by: Axel Lin axel@ingics.com

Re: [PATCH] mfd: stw481x: Remove unused fields from struct stw481x

2015-02-16 Thread Lee Jones
On Fri, 13 Feb 2015, Axel Lin wrote: > The mutex lock is not used at all, remove it. > The *vmmc_regulator is not necessary, use a local variable in > stw481x_vmmc_regulator_probe() instead. > > Signed-off-by: Axel Lin > --- > drivers/regulator/stw481x-vmmc.c | 8 >

Re: [PATCH] mfd: stw481x: Remove unused fields from struct stw481x

2015-02-16 Thread Linus Walleij
On Fri, Feb 13, 2015 at 6:28 AM, Axel Lin wrote: > The mutex lock is not used at all, remove it. > The *vmmc_regulator is not necessary, use a local variable in > stw481x_vmmc_regulator_probe() instead. > > Signed-off-by: Axel Lin Reviewed-by: Linus Walleij Thanks a lot Axel! Yours, Linus

Re: [PATCH] mfd: stw481x: Remove unused fields from struct stw481x

2015-02-16 Thread Linus Walleij
On Fri, Feb 13, 2015 at 6:28 AM, Axel Lin axel@ingics.com wrote: The mutex lock is not used at all, remove it. The *vmmc_regulator is not necessary, use a local variable in stw481x_vmmc_regulator_probe() instead. Signed-off-by: Axel Lin axel@ingics.com Reviewed-by: Linus Walleij

Re: [PATCH] mfd: stw481x: Remove unused fields from struct stw481x

2015-02-16 Thread Lee Jones
On Fri, 13 Feb 2015, Axel Lin wrote: The mutex lock is not used at all, remove it. The *vmmc_regulator is not necessary, use a local variable in stw481x_vmmc_regulator_probe() instead. Signed-off-by: Axel Lin axel@ingics.com --- drivers/regulator/stw481x-vmmc.c | 8

[PATCH] mfd: stw481x: Remove unused fields from struct stw481x

2015-02-12 Thread Axel Lin
The mutex lock is not used at all, remove it. The *vmmc_regulator is not necessary, use a local variable in stw481x_vmmc_regulator_probe() instead. Signed-off-by: Axel Lin --- drivers/regulator/stw481x-vmmc.c | 8 include/linux/mfd/stw481x.h | 4 2 files changed, 4

[PATCH] mfd: stw481x: Remove unused fields from struct stw481x

2015-02-12 Thread Axel Lin
The mutex lock is not used at all, remove it. The *vmmc_regulator is not necessary, use a local variable in stw481x_vmmc_regulator_probe() instead. Signed-off-by: Axel Lin axel@ingics.com --- drivers/regulator/stw481x-vmmc.c | 8 include/linux/mfd/stw481x.h | 4 2 files