Re: [PATCH] minor ne2k-pci irq fix

2001-02-03 Thread Linus Torvalds
On Thu, 1 Feb 2001, Jeff Garzik wrote: > > > Probably I've missed this because the last time I hit such a thing was > > when my ob800 bios mapped the cardbus memory BAR's into bogus legacy > > 0xe area. Hence there was good reason to read and correct this before > > trying to enable the dev

Re: [PATCH] minor ne2k-pci irq fix

2001-02-02 Thread Jeff Garzik
On Fri, 2 Feb 2001, Martin Diehl wrote: > Sorry, wasn't clear enough. I've meant, the kernel (PCI stuff) changing > the BAR bus address in the config space when enabling the device (i.e. > the bus address value which is used for later mapping). Doing so would > make the pci_resource_start() value

Re: [PATCH] minor ne2k-pci irq fix

2001-02-02 Thread Martin Diehl
(apologies in case anybody should get this twice - was catched by the DUL blocker again. Seems time to change my mail routing anyway...) On Thu, 1 Feb 2001, Jeff Garzik wrote: > > Probably I've missed this because the last time I hit such a thing was > > when my ob800 bios mapped the cardbus me

Re: [PATCH] minor ne2k-pci irq fix

2001-02-01 Thread Jeff Garzik
On Thu, 1 Feb 2001, Martin Diehl wrote: > On Wed, 31 Jan 2001 [EMAIL PROTECTED] wrote: > > I think it would be better to move the pci_enable_device(pdev); > > above all this, as we should enable the device before reading the > > pdev->resource[] too iirc. Agreed. > Probably I've missed this bec

Re: [PATCH] minor ne2k-pci irq fix

2001-01-31 Thread Martin Diehl
On Wed, 31 Jan 2001 [EMAIL PROTECTED] wrote: > I think it would be better to move the pci_enable_device(pdev); > above all this, as we should enable the device before reading the > pdev->resource[] too iirc. Probably I've missed this because the last time I hit such a thing was when my ob800 bio

Re: [PATCH] minor ne2k-pci irq fix

2001-01-31 Thread davej
On Wed, 31 Jan 2001, Martin Diehl wrote: > Reason: we fetched the irq too early, before calling pci_enable_device(), > so it was bogus after initial routing. > Patch below (prepared for 2.4.0 - should be fine for 2.4.1 too). I think it would be better to move the pci_enable_device(pdev); above a

[PATCH] minor ne2k-pci irq fix

2001-01-31 Thread Martin Diehl
Hi, while testing the SiS routing code, at some point my ne2k-pci didn't work anymore. Was when BIOS was set for PnP OS and IRQ set to "auto" for the NIC. Had to rmmod/insmod the ne2k-pci module after reboot to make it working again. Reason: we fetched the irq too early, before calling pci_enab