Re: [PATCH] mips: Save all registers when saving the frame

2014-09-23 Thread Corey Minyard
Ping? I haven't heard anything on this. Thanks, -corey On 09/18/2014 07:58 AM, Corey Minyard wrote: > On 09/18/2014 04:58 AM, Ralf Baechle wrote: >> On Tue, Sep 16, 2014 at 04:45:25PM -0500, miny...@acm.org wrote: >> >>> From: Corey Minyard >>> >>> The MIPS frame save code was just saving a fe

Re: [PATCH] mips: Save all registers when saving the frame

2014-09-18 Thread Corey Minyard
On 09/18/2014 04:58 AM, Ralf Baechle wrote: > On Tue, Sep 16, 2014 at 04:45:25PM -0500, miny...@acm.org wrote: > >> From: Corey Minyard >> >> The MIPS frame save code was just saving a few registers, enough to >> do a backtrace if every function set up a frame. However, this is >> not working if

Re: [PATCH] mips: Save all registers when saving the frame

2014-09-18 Thread Ralf Baechle
On Tue, Sep 16, 2014 at 04:45:25PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > The MIPS frame save code was just saving a few registers, enough to > do a backtrace if every function set up a frame. However, this is > not working if you are using DWARF unwinding, because most of the

Re: [PATCH] mips: Save all registers when saving the frame

2014-09-16 Thread Corey Minyard
Well, there's a bug I noticed in this patch, $1 is restored from the wrong location. I'm not sure $1 ($at) needs to be restored at all, really. I guess make this a RFC. -corey On 09/16/2014 04:45 PM, miny...@acm.org wrote: > From: Corey Minyard > > The MIPS frame save code was just saving a fe

[PATCH] mips: Save all registers when saving the frame

2014-09-16 Thread minyard
From: Corey Minyard The MIPS frame save code was just saving a few registers, enough to do a backtrace if every function set up a frame. However, this is not working if you are using DWARF unwinding, because most of the registers are wrong. This was causing kdump backtraces to be short or bogus