Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

2019-08-26 Thread Nick Desaulniers
On Sat, Aug 24, 2019 at 7:12 AM Paul Burton wrote: > > Hi Nick, > > On Fri, Aug 23, 2019 at 10:16:04AM -0700, Nick Desaulniers wrote: > > On Tue, Aug 20, 2019 at 10:15 AM Nick Desaulniers > > wrote: > > > Hi Paul, > > > Bumping this thread; we'd really like to be able to boot test another > > > I

Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

2019-08-24 Thread Paul Burton
Hello, Nick Desaulniers wrote: > The code in question is modifying a variable declared const through > pointer manipulation. Such code is explicitly undefined behavior, and > is the lone issue preventing malta_defconfig from booting when built > with Clang: > > If an attempt is made to modify an

Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

2019-08-24 Thread Paul Burton
Hi Nick, On Fri, Aug 23, 2019 at 10:16:04AM -0700, Nick Desaulniers wrote: > On Tue, Aug 20, 2019 at 10:15 AM Nick Desaulniers > wrote: > > Hi Paul, > > Bumping this thread; we'd really like to be able to boot test another > > ISA in our CI. This lone patch is affecting our ability to boot. Can

Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

2019-08-23 Thread Nick Desaulniers
On Tue, Aug 20, 2019 at 10:15 AM Nick Desaulniers wrote: > > Hi Paul, > Bumping this thread; we'd really like to be able to boot test another > ISA in our CI. This lone patch is affecting our ability to boot. Can > you please pick it up? > https://lore.kernel.org/lkml/20190729211014.39333-1-ndes

Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

2019-08-20 Thread Nick Desaulniers
Hi Paul, Bumping this thread; we'd really like to be able to boot test another ISA in our CI. This lone patch is affecting our ability to boot. Can you please pick it up? https://lore.kernel.org/lkml/20190729211014.39333-1-ndesaulni...@google.com/ On Wed, Aug 7, 2019 at 2:12 PM Nick Desaulniers

Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

2019-08-07 Thread Nick Desaulniers
Sorry for the delayed response, literally sent the patch then went on vacation. On Mon, Jul 29, 2019 at 3:16 PM Maciej W. Rozycki wrote: > > On Mon, 29 Jul 2019, Nick Desaulniers wrote: > > > The code in question is modifying a variable declared const through > > pointer manipulation. Such code

Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

2019-07-30 Thread Paul Burton
Hello, On Mon, Jul 29, 2019 at 11:16:45PM +0100, Maciej W. Rozycki wrote: > On Mon, 29 Jul 2019, Nick Desaulniers wrote: > > The code in question is modifying a variable declared const through > > pointer manipulation. Such code is explicitly undefined behavior, and > > is the lone issue preventi

Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

2019-07-29 Thread Maciej W. Rozycki
On Mon, 29 Jul 2019, Nick Desaulniers wrote: > The code in question is modifying a variable declared const through > pointer manipulation. Such code is explicitly undefined behavior, and > is the lone issue preventing malta_defconfig from booting when built > with Clang: > > If an attempt is mad

Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

2019-07-29 Thread Nathan Chancellor
On Mon, Jul 29, 2019 at 02:10:12PM -0700, Nick Desaulniers wrote: > The code in question is modifying a variable declared const through > pointer manipulation. Such code is explicitly undefined behavior, and > is the lone issue preventing malta_defconfig from booting when built > with Clang: > >

[PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

2019-07-29 Thread Nick Desaulniers
The code in question is modifying a variable declared const through pointer manipulation. Such code is explicitly undefined behavior, and is the lone issue preventing malta_defconfig from booting when built with Clang: If an attempt is made to modify an object defined with a const-qualified type