Re: [PATCH] misc: eeprom: assignment outside the if statement

2018-08-03 Thread Parth Shah
Hello Jean, Thank you for your response. So, can we consider this patch? Regards, Parth Y Shah On Fri, Aug 3, 2018 at 6:06 PM Jean Delvare wrote: > On Fri, 3 Aug 2018 14:50:43 +0530, Parth Y Shah wrote: > > Assignment of any variable should be kept outside the if statement > > Actually

Re: [PATCH] misc: eeprom: assignment outside the if statement

2018-08-03 Thread Parth Shah
Hello Jean, Thank you for your response. So, can we consider this patch? Regards, Parth Y Shah On Fri, Aug 3, 2018 at 6:06 PM Jean Delvare wrote: > On Fri, 3 Aug 2018 14:50:43 +0530, Parth Y Shah wrote: > > Assignment of any variable should be kept outside the if statement > > Actually

Re: [PATCH] misc: eeprom: assignment outside the if statement

2018-08-03 Thread Jean Delvare
On Fri, 3 Aug 2018 14:50:43 +0530, Parth Y Shah wrote: > Assignment of any variable should be kept outside the if statement Actually there are exceptions to that rule, but this isn't one of them. > Signed-off-by: Parth Y Shah > --- > drivers/misc/eeprom/max6875.c | 3 ++- > 1 file changed, 2

Re: [PATCH] misc: eeprom: assignment outside the if statement

2018-08-03 Thread Jean Delvare
On Fri, 3 Aug 2018 14:50:43 +0530, Parth Y Shah wrote: > Assignment of any variable should be kept outside the if statement Actually there are exceptions to that rule, but this isn't one of them. > Signed-off-by: Parth Y Shah > --- > drivers/misc/eeprom/max6875.c | 3 ++- > 1 file changed, 2

[PATCH] misc: eeprom: assignment outside the if statement

2018-08-03 Thread Parth Y Shah
Assignment of any variable should be kept outside the if statement Signed-off-by: Parth Y Shah --- drivers/misc/eeprom/max6875.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/eeprom/max6875.c b/drivers/misc/eeprom/max6875.c index 0e32709..fc0cf9a 100644 ---

[PATCH] misc: eeprom: assignment outside the if statement

2018-08-03 Thread Parth Y Shah
Assignment of any variable should be kept outside the if statement Signed-off-by: Parth Y Shah --- drivers/misc/eeprom/max6875.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/eeprom/max6875.c b/drivers/misc/eeprom/max6875.c index 0e32709..fc0cf9a 100644 ---