Re: [PATCH] misc: rtsx: release IRQ during shutdown

2018-01-03 Thread Sinan Kaya
On 1/3/2018 7:06 AM, Rafael J. Wysocki wrote: >> pci_disable_device(pcidev); >> + free_irq(pcr->irq, (void *)pcr); > Do you need to disable MSI here too? > Makes sense. I'll post V2 in a minute. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm

Re: [PATCH] misc: rtsx: release IRQ during shutdown

2018-01-03 Thread Sinan Kaya
On 1/3/2018 7:06 AM, Rafael J. Wysocki wrote: >> pci_disable_device(pcidev); >> + free_irq(pcr->irq, (void *)pcr); > Do you need to disable MSI here too? > Makes sense. I'll post V2 in a minute. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm

Re: [PATCH] misc: rtsx: release IRQ during shutdown

2018-01-03 Thread Rafael J. Wysocki
On Tue, Jan 2, 2018 at 9:45 PM, Sinan Kaya wrote: > 'Commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during > shutdown")' revealed a resource leak in rtsx_pci driver during shutdown. > > Issue shows up as a warning during the shutdown step as follows: > >

Re: [PATCH] misc: rtsx: release IRQ during shutdown

2018-01-03 Thread Rafael J. Wysocki
On Tue, Jan 2, 2018 at 9:45 PM, Sinan Kaya wrote: > 'Commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during > shutdown")' revealed a resource leak in rtsx_pci driver during shutdown. > > Issue shows up as a warning during the shutdown step as follows: > > remove_proc_entry: removing

[PATCH] misc: rtsx: release IRQ during shutdown

2018-01-02 Thread Sinan Kaya
'Commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during shutdown")' revealed a resource leak in rtsx_pci driver during shutdown. Issue shows up as a warning during the shutdown step as follows: remove_proc_entry: removing non-empty directory 'irq/17', leaking at least 'rtsx_pci'

[PATCH] misc: rtsx: release IRQ during shutdown

2018-01-02 Thread Sinan Kaya
'Commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during shutdown")' revealed a resource leak in rtsx_pci driver during shutdown. Issue shows up as a warning during the shutdown step as follows: remove_proc_entry: removing non-empty directory 'irq/17', leaking at least 'rtsx_pci'