Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

2016-07-14 Thread David Miller
From: Jiri Pirko Date: Thu, 14 Jul 2016 08:28:19 +0200 > Thu, Jul 14, 2016 at 08:18:45AM CEST, christophe.jail...@wanadoo.fr wrote: >>'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong. >>Return an explicit error code (-ENOENT) instead. >> > > This is fo

Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

2016-07-14 Thread David Miller
From: Jiri Pirko Date: Thu, 14 Jul 2016 08:28:19 +0200 > Thu, Jul 14, 2016 at 08:18:45AM CEST, christophe.jail...@wanadoo.fr wrote: >>'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong. >>Return an explicit error code (-ENOENT) instead. >> > > This is fo net-next. > >

Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

2016-07-14 Thread Jiri Pirko
Thu, Jul 14, 2016 at 08:18:45AM CEST, christophe.jail...@wanadoo.fr wrote: >'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong. >Return an explicit error code (-ENOENT) instead. > This is fo net-next. Fixes: 61c503f976 ("mlxsw: spectrum_router: Implement fib4 add/del

Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

2016-07-14 Thread Jiri Pirko
Thu, Jul 14, 2016 at 08:18:45AM CEST, christophe.jail...@wanadoo.fr wrote: >'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong. >Return an explicit error code (-ENOENT) instead. > This is fo net-next. Fixes: 61c503f976 ("mlxsw: spectrum_router: Implement fib4 add/del

[PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

2016-07-14 Thread Christophe JAILLET
'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong. Return an explicit error code (-ENOENT) instead. Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

2016-07-14 Thread Christophe JAILLET
'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong. Return an explicit error code (-ENOENT) instead. Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git