Re: [PATCH] mm, oom: remove 'prefer children over parent' heuristic

2019-01-21 Thread Shakeel Butt
On Mon, Jan 21, 2019 at 1:19 AM Michal Hocko wrote: > > On Sun 20-01-19 13:50:59, Shakeel Butt wrote: > > >From the start of the git history of Linux, the kernel after selecting > > the worst process to be oom-killed, prefer to kill its child (if the > > child does not share mm with the parent).

Re: [PATCH] mm, oom: remove 'prefer children over parent' heuristic

2019-01-21 Thread Shakeel Butt
On Sun, Jan 20, 2019 at 5:23 PM Tetsuo Handa wrote: > > Shakeel Butt wrote: > > + pr_err("%s: Kill process %d (%s) score %lu or sacrifice child\n", > > + message, task_pid_nr(p), p->comm, oc->chosen_points); > > This patch is to make "or sacrifice child" false. And, the process

Re: [PATCH] mm, oom: remove 'prefer children over parent' heuristic

2019-01-21 Thread Michal Hocko
On Sun 20-01-19 13:50:59, Shakeel Butt wrote: > >From the start of the git history of Linux, the kernel after selecting > the worst process to be oom-killed, prefer to kill its child (if the > child does not share mm with the parent). Later it was changed to prefer > to kill a child who is worst.

[PATCH] mm, oom: remove 'prefer children over parent' heuristic

2019-01-21 Thread Shakeel Butt
>From the start of the git history of Linux, the kernel after selecting the worst process to be oom-killed, prefer to kill its child (if the child does not share mm with the parent). Later it was changed to prefer to kill a child who is worst. If the parent is still the worst then the parent will

Re: [PATCH] mm, oom: remove 'prefer children over parent' heuristic

2019-01-20 Thread Tetsuo Handa
Shakeel Butt wrote: > + pr_err("%s: Kill process %d (%s) score %lu or sacrifice child\n", > + message, task_pid_nr(p), p->comm, oc->chosen_points); This patch is to make "or sacrifice child" false. And, the process reported by this line will become always same with the process