Re: [PATCH] mm,hwpoison: Return -EBUSY when migration fails

2020-12-09 Thread Oscar Salvador
On Wed, Dec 09, 2020 at 11:25:31AM +0100, Vlastimil Babka wrote: > On 12/9/20 10:28 AM, Oscar Salvador wrote: > > Currently, we return -EIO when we fail to migrate the page. > > > > Migrations' failures are rather transient as they can happen due to > > several reasons, e.g: high page refcount

Re: [PATCH] mm,hwpoison: Return -EBUSY when migration fails

2020-12-09 Thread Oscar Salvador
On Wed, Dec 09, 2020 at 10:59:04AM +0100, David Hildenbrand wrote: > On 09.12.20 10:28, Oscar Salvador wrote: > Do we expect callers to retry immediately? -EAGAIN might make also > sense. But -EBUSY is an obvious improvement. Do we have callers relying > on this behavior? Not really, unless

Re: [PATCH] mm,hwpoison: Return -EBUSY when migration fails

2020-12-09 Thread Vlastimil Babka
On 12/9/20 10:28 AM, Oscar Salvador wrote: > Currently, we return -EIO when we fail to migrate the page. > > Migrations' failures are rather transient as they can happen due to > several reasons, e.g: high page refcount bump, mapping->migrate_page > failing etc. > All meaning that at that time

Re: [PATCH] mm,hwpoison: Return -EBUSY when migration fails

2020-12-09 Thread David Hildenbrand
On 09.12.20 10:28, Oscar Salvador wrote: > Currently, we return -EIO when we fail to migrate the page. > > Migrations' failures are rather transient as they can happen due to > several reasons, e.g: high page refcount bump, mapping->migrate_page > failing etc. > All meaning that at that time the

Re: [PATCH] mm,hwpoison: Return -EBUSY when migration fails

2020-12-09 Thread 堀口 直也
On Wed, Dec 09, 2020 at 10:28:18AM +0100, Oscar Salvador wrote: > Currently, we return -EIO when we fail to migrate the page. > > Migrations' failures are rather transient as they can happen due to > several reasons, e.g: high page refcount bump, mapping->migrate_page > failing etc. > All meaning

[PATCH] mm,hwpoison: Return -EBUSY when migration fails

2020-12-09 Thread Oscar Salvador
Currently, we return -EIO when we fail to migrate the page. Migrations' failures are rather transient as they can happen due to several reasons, e.g: high page refcount bump, mapping->migrate_page failing etc. All meaning that at that time the page could not be migrated, but that has nothing to