Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-22 Thread Christoph Hellwig
On Mon, Jul 22, 2019 at 08:58:04AM -0300, Jason Gunthorpe wrote: > No one has given me a satisfactory answer about the restriction > either. > > The only thing this kconfig controls that could possibly be arch > specific is the page walking code in hmm_range_snapshot and > related. > > Maybe the

Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-22 Thread Jason Gunthorpe
On Fri, Jul 19, 2019 at 01:38:28PM -0700, John Hubbard wrote: > On 7/19/19 5:04 AM, Pavel Machek wrote: > > On Fri 2019-07-19 05:00:43, Christoph Hellwig wrote: > >> On Fri, Jul 19, 2019 at 08:48:53AM -0300, Jason Gunthorpe wrote: > >>> It is like MMU_NOTIFIERS, if something needs it, then it will

Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-19 Thread John Hubbard
On 7/19/19 5:04 AM, Pavel Machek wrote: > On Fri 2019-07-19 05:00:43, Christoph Hellwig wrote: >> On Fri, Jul 19, 2019 at 08:48:53AM -0300, Jason Gunthorpe wrote: >>> It is like MMU_NOTIFIERS, if something needs it, then it will select >>> it. >>> >>> Maybe it should just be a hidden kconfig anyhow

Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-19 Thread Pavel Machek
On Fri 2019-07-19 05:00:43, Christoph Hellwig wrote: > On Fri, Jul 19, 2019 at 08:48:53AM -0300, Jason Gunthorpe wrote: > > It is like MMU_NOTIFIERS, if something needs it, then it will select > > it. > > > > Maybe it should just be a hidden kconfig anyhow as there is no reason > > to turn it on w

Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-19 Thread Christoph Hellwig
On Fri, Jul 19, 2019 at 08:48:53AM -0300, Jason Gunthorpe wrote: > It is like MMU_NOTIFIERS, if something needs it, then it will select > it. > > Maybe it should just be a hidden kconfig anyhow as there is no reason > to turn it on without also turning on a using driver. We can't just select it d

Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-19 Thread Jason Gunthorpe
On Fri, Jul 19, 2019 at 12:52:39PM +0200, Pavel Machek wrote: > On Thu 2019-07-18 22:57:48, Christoph Hellwig wrote: > > On Thu, Jul 18, 2019 at 06:32:53PM -0700, john.hubb...@gmail.com wrote: > > > + HMM_MIRROR provides a way to mirror ranges of the CPU page tables > > > + of a process into a

Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-19 Thread Pavel Machek
On Thu 2019-07-18 22:57:48, Christoph Hellwig wrote: > On Thu, Jul 18, 2019 at 06:32:53PM -0700, john.hubb...@gmail.com wrote: > > + HMM_MIRROR provides a way to mirror ranges of the CPU page tables > > + of a process into a device page table. Here, mirror means "keep > > + synchronized

Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-18 Thread Christoph Hellwig
On Thu, Jul 18, 2019 at 06:32:53PM -0700, john.hubb...@gmail.com wrote: > + HMM_MIRROR provides a way to mirror ranges of the CPU page tables > + of a process into a device page table. Here, mirror means "keep > + synchronized". Prerequisites: the device must provide the ability >

Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-18 Thread John Hubbard
On 7/18/19 9:34 PM, Ira Weiny wrote: > On Thu, Jul 18, 2019 at 06:32:53PM -0700, john.hubb...@gmail.com wrote: >> From: John Hubbard ... >> + Select HMM_MIRROR if you have hardware that meets the above >> + description. An early, partial list of such hardware is: >> + an NVIDIA GPU

Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-18 Thread Ira Weiny
On Thu, Jul 18, 2019 at 06:32:53PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > The HMM_MIRROR option in Kconfig is a little underdocumented and > mysterious, and leaves people wondering whether to enable it. > > Add text explaining just a little bit more about HMM, and also > m

[PATCH] mm/Kconfig: additional help text for HMM_MIRROR option

2019-07-18 Thread john . hubbard
From: John Hubbard The HMM_MIRROR option in Kconfig is a little underdocumented and mysterious, and leaves people wondering whether to enable it. Add text explaining just a little bit more about HMM, and also mention which hardware would benefit from having HMM_MIRROR enabled. Suggested-by: Pav