Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-06-01 Thread Baoquan He
On 06/01/20 at 02:42pm, Mike Rapoport wrote: > On Thu, May 28, 2020 at 10:15:10AM -0500, Steve Wahl wrote: > > On Thu, May 28, 2020 at 05:07:31PM +0800, Baoquan He wrote: > > > On 05/26/20 at 01:49pm, David Hildenbrand wrote: > > > > On 26.05.20 13:32, Mike Rapoport wrote: > > > > > Hello Baoquan,

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-06-01 Thread Mike Rapoport
On Thu, May 28, 2020 at 10:15:10AM -0500, Steve Wahl wrote: > On Thu, May 28, 2020 at 05:07:31PM +0800, Baoquan He wrote: > > On 05/26/20 at 01:49pm, David Hildenbrand wrote: > > > On 26.05.20 13:32, Mike Rapoport wrote: > > > > Hello Baoquan, > > > > > > > > I do not object to your original fix w

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-28 Thread Steve Wahl
On Thu, May 28, 2020 at 05:07:31PM +0800, Baoquan He wrote: > On 05/26/20 at 01:49pm, David Hildenbrand wrote: > > On 26.05.20 13:32, Mike Rapoport wrote: > > > Hello Baoquan, > > > > > > On Tue, May 26, 2020 at 04:45:43PM +0800, Baoquan He wrote: > > >> On 05/22/20 at 05:20pm, Mike Rapoport wrote

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-28 Thread David Hildenbrand
On 28.05.20 11:07, Baoquan He wrote: > On 05/26/20 at 01:49pm, David Hildenbrand wrote: >> On 26.05.20 13:32, Mike Rapoport wrote: >>> Hello Baoquan, >>> >>> On Tue, May 26, 2020 at 04:45:43PM +0800, Baoquan He wrote: On 05/22/20 at 05:20pm, Mike Rapoport wrote: > Hello Baoquan, >

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages() 

2020-05-28 Thread Baoquan He
On 05/28/20 at 04:59pm, Baoquan He wrote: > a...@linux-foundation.org, c...@lca.pw, mho...@kernel.org, > steve.w...@hpe.com, > Bcc: b...@redhat.com > Subject: Re: [PATCH] mm/compaction: Fix the incorrect hole in > fast_isolate_freepages() > Reply-To: > In-Reply-To: <

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-28 Thread Baoquan He
On 05/26/20 at 01:49pm, David Hildenbrand wrote: > On 26.05.20 13:32, Mike Rapoport wrote: > > Hello Baoquan, > > > > On Tue, May 26, 2020 at 04:45:43PM +0800, Baoquan He wrote: > >> On 05/22/20 at 05:20pm, Mike Rapoport wrote: > >>> Hello Baoquan, > >>> > >>> On Fri, May 22, 2020 at 03:25:24PM +0

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages() 

2020-05-28 Thread Baoquan He
a...@linux-foundation.org, c...@lca.pw, mho...@kernel.org, steve.w...@hpe.com, Bcc: b...@redhat.com Subject: Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages() Reply-To: In-Reply-To: <01beec81-565f-d335-5eff-22693fc09...@redhat.com> On 05/26/20 at 01:49pm,

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-26 Thread David Hildenbrand
On 26.05.20 13:32, Mike Rapoport wrote: > Hello Baoquan, > > On Tue, May 26, 2020 at 04:45:43PM +0800, Baoquan He wrote: >> On 05/22/20 at 05:20pm, Mike Rapoport wrote: >>> Hello Baoquan, >>> >>> On Fri, May 22, 2020 at 03:25:24PM +0800, Baoquan He wrote: On 05/22/20 at 03:01pm, Baoquan He wr

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-26 Thread Mike Rapoport
Hello Baoquan, On Tue, May 26, 2020 at 04:45:43PM +0800, Baoquan He wrote: > On 05/22/20 at 05:20pm, Mike Rapoport wrote: > > Hello Baoquan, > > > > On Fri, May 22, 2020 at 03:25:24PM +0800, Baoquan He wrote: > > > On 05/22/20 at 03:01pm, Baoquan He wrote: > > > > > > > > So let's add these unav

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-26 Thread David Hildenbrand
On 26.05.20 10:45, Baoquan He wrote: > On 05/22/20 at 05:20pm, Mike Rapoport wrote: >> Hello Baoquan, >> >> On Fri, May 22, 2020 at 03:25:24PM +0800, Baoquan He wrote: >>> On 05/22/20 at 03:01pm, Baoquan He wrote: So let's add these unavailable ranges into memblock and reserve them i

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-26 Thread Baoquan He
On 05/22/20 at 05:20pm, Mike Rapoport wrote: > Hello Baoquan, > > On Fri, May 22, 2020 at 03:25:24PM +0800, Baoquan He wrote: > > On 05/22/20 at 03:01pm, Baoquan He wrote: > > > > > > So let's add these unavailable ranges into memblock and reserve them > > > in init_unavailable_range() instead. W

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-22 Thread Mike Rapoport
Hello Baoquan, On Fri, May 22, 2020 at 03:25:24PM +0800, Baoquan He wrote: > On 05/22/20 at 03:01pm, Baoquan He wrote: > > > > So let's add these unavailable ranges into memblock and reserve them > > in init_unavailable_range() instead. With this change, they will be added > > into appropriate no

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-22 Thread Baoquan He
On 05/22/20 at 03:01pm, Baoquan He wrote: > > > As I said, the unavailable range includes firmware reserved ranges, and > > > holes inside one boot memory section, if that boot memory section haves > > > useable memory range, and firmware reserved ranges, and holes. Adding > > > them all into membl

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-22 Thread Baoquan He
On 05/21/20 at 08:18pm, Mike Rapoport wrote: > On Thu, May 21, 2020 at 11:52:25PM +0800, Baoquan He wrote: > > On 05/21/20 at 12:26pm, Mike Rapoport wrote: > > > > For this kind of e820 reserved range, it won't be added to memblock > > > > allocator. > > > > However, init_unavailable_mem() will in

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-21 Thread Mike Rapoport
On Thu, May 21, 2020 at 11:52:25PM +0800, Baoquan He wrote: > On 05/21/20 at 12:26pm, Mike Rapoport wrote: > > > For this kind of e820 reserved range, it won't be added to memblock > > > allocator. > > > However, init_unavailable_mem() will initialize to add them into node 0, > > > zone 0. Before

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-21 Thread Baoquan He
On 05/21/20 at 12:26pm, Mike Rapoport wrote: > > For this kind of e820 reserved range, it won't be added to memblock > > allocator. > > However, init_unavailable_mem() will initialize to add them into node 0, > > zone 0. Before that commit, later, memmap_init() will add e820 reserved > > ranges in

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-21 Thread Baoquan He
On 05/21/20 at 10:36am, Mel Gorman wrote: > On Thu, May 21, 2020 at 09:44:07AM +0800, Baoquan He wrote: > > After investigation, it turns out that this is introduced by commit of > > linux-next: commit f6edbdb71877 ("mm: memmap_init: iterate over memblock > > regions rather that check each PFN"). >

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-21 Thread Mike Rapoport
On Thu, May 21, 2020 at 10:36:06AM +0100, Mel Gorman wrote: > On Thu, May 21, 2020 at 09:44:07AM +0800, Baoquan He wrote: > > After investigation, it turns out that this is introduced by commit of > > linux-next: commit f6edbdb71877 ("mm: memmap_init: iterate over memblock > > regions rather that c

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-21 Thread Mel Gorman
On Thu, May 21, 2020 at 09:44:07AM +0800, Baoquan He wrote: > After investigation, it turns out that this is introduced by commit of > linux-next: commit f6edbdb71877 ("mm: memmap_init: iterate over memblock > regions rather that check each PFN"). > > After investigation, it turns out that this is

Re: [PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-21 Thread Mike Rapoport
Hi Baoquan, On Thu, May 21, 2020 at 09:44:07AM +0800, Baoquan He wrote: > Qian reported that a crash happened in compaction. > http://lkml.kernel.org/r/8c537eb7-85ee-4dcf-943e-3cc0ed0df...@lca.pw > V> LTP: starting swapping01 (swapping01 -i 5) > page:eaaa refcount:1 mapcount:0 mapping

[PATCH] mm/compaction: Fix the incorrect hole in fast_isolate_freepages()

2020-05-20 Thread Baoquan He
Qian reported that a crash happened in compaction. http://lkml.kernel.org/r/8c537eb7-85ee-4dcf-943e-3cc0ed0df...@lca.pw LTP: starting swapping01 (swapping01 -i 5) page:eaaa refcount:1 mapcount:0 mapping:2243743b index:0x0 flags: 0x1fffe01000(reserved) raw: 001fffe01000