Re: [PATCH] mm/gup.c: fix the wrong comments

2019-04-07 Thread Huang Shijie
On Thu, Apr 04, 2019 at 09:50:47AM -0700, Ira Weiny wrote: > On Thu, Apr 04, 2019 at 03:23:47PM +0800, Huang Shijie wrote: > > When CONFIG_HAVE_GENERIC_GUP is defined, the kernel will use its own > > get_user_pages_fast(). > > > > In the following scenario, we will may meet the bug in the DMA

RE: [PATCH] mm/gup.c: fix the wrong comments

2019-04-04 Thread Weiny, Ira
> > On Apr 4, 2019, at 1:23 AM, Huang Shijie wrote: > > > > > > + * This function is different from the get_user_pages_unlocked(): > > + * The @pages may has different page order with the result > > + * got by get_user_pages_unlocked(). > > + * > > I suggest a slight rewrite of the

Re: [PATCH] mm/gup.c: fix the wrong comments

2019-04-04 Thread Ira Weiny
On Thu, Apr 04, 2019 at 03:23:47PM +0800, Huang Shijie wrote: > When CONFIG_HAVE_GENERIC_GUP is defined, the kernel will use its own > get_user_pages_fast(). > > In the following scenario, we will may meet the bug in the DMA case: > . >

Re: [PATCH] mm/gup.c: fix the wrong comments

2019-04-04 Thread William Kucharski
> On Apr 4, 2019, at 1:23 AM, Huang Shijie wrote: > > > + * This function is different from the get_user_pages_unlocked(): > + * The @pages may has different page order with the result > + * got by get_user_pages_unlocked(). > + * I suggest a slight rewrite of the comment,

[PATCH] mm/gup.c: fix the wrong comments

2019-04-04 Thread Huang Shijie
When CONFIG_HAVE_GENERIC_GUP is defined, the kernel will use its own get_user_pages_fast(). In the following scenario, we will may meet the bug in the DMA case: . get_user_pages_fast(start,,, pages); ..