Re: [PATCH] mm/hmm: remove redundant check non_swap_entry()

2020-06-12 Thread Jason Gunthorpe
On Fri, Jun 12, 2020 at 12:53:23PM -0700, Ralph Campbell wrote: > > On 6/12/20 12:42 PM, Jason Gunthorpe wrote: > > On Fri, Jun 12, 2020 at 12:35:24PM -0700, Matthew Wilcox wrote: > > > On Fri, Jun 12, 2020 at 12:26:18PM -0700, Ralph Campbell wrote: > > > > In zap_pte_range(), the check for

Re: [PATCH] mm/hmm: remove redundant check non_swap_entry()

2020-06-12 Thread Ralph Campbell
On 6/12/20 12:42 PM, Jason Gunthorpe wrote: On Fri, Jun 12, 2020 at 12:35:24PM -0700, Matthew Wilcox wrote: On Fri, Jun 12, 2020 at 12:26:18PM -0700, Ralph Campbell wrote: In zap_pte_range(), the check for non_swap_entry() and is_device_private_entry() is redundant since the latter is a

Re: [PATCH] mm/hmm: remove redundant check non_swap_entry()

2020-06-12 Thread Ralph Campbell
On 6/12/20 12:33 PM, Jason Gunthorpe wrote: On Fri, Jun 12, 2020 at 12:26:18PM -0700, Ralph Campbell wrote: In zap_pte_range(), the check for non_swap_entry() and is_device_private_entry() is redundant since the latter is a subset of the former. Remove the redundant check to simplify the code

Re: [PATCH] mm/hmm: remove redundant check non_swap_entry()

2020-06-12 Thread Jason Gunthorpe
On Fri, Jun 12, 2020 at 12:35:24PM -0700, Matthew Wilcox wrote: > On Fri, Jun 12, 2020 at 12:26:18PM -0700, Ralph Campbell wrote: > > In zap_pte_range(), the check for non_swap_entry() and > > is_device_private_entry() is redundant since the latter is a subset of the > > former. Remove the

Re: [PATCH] mm/hmm: remove redundant check non_swap_entry()

2020-06-12 Thread Matthew Wilcox
On Fri, Jun 12, 2020 at 12:26:18PM -0700, Ralph Campbell wrote: > In zap_pte_range(), the check for non_swap_entry() and > is_device_private_entry() is redundant since the latter is a subset of the > former. Remove the redundant check to simplify the code and for clarity. That is highly

Re: [PATCH] mm/hmm: remove redundant check non_swap_entry()

2020-06-12 Thread Jason Gunthorpe
On Fri, Jun 12, 2020 at 12:26:18PM -0700, Ralph Campbell wrote: > In zap_pte_range(), the check for non_swap_entry() and > is_device_private_entry() is redundant since the latter is a subset of the > former. Remove the redundant check to simplify the code and for clarity. > > Signed-off-by: Ralph

[PATCH] mm/hmm: remove redundant check non_swap_entry()

2020-06-12 Thread Ralph Campbell
In zap_pte_range(), the check for non_swap_entry() and is_device_private_entry() is redundant since the latter is a subset of the former. Remove the redundant check to simplify the code and for clarity. Signed-off-by: Ralph Campbell --- This is based on the current linux tree and is intended