Re: [PATCH] mm/hugetlb: Fix potential double free in hugetlb_register_node() error path

2021-01-08 Thread Muchun Song
On Thu, Jan 7, 2021 at 8:36 PM Miaohe Lin wrote: > > In hugetlb_sysfs_add_hstate(), we would do kobject_put() on hstate_kobjs > when failed to create sysfs group but forget to set hstate_kobjs to NULL. > Then in hugetlb_register_node() error path, we may free it again via > hugetlb_unregister_node

Re: [PATCH] mm/hugetlb: Fix potential double free in hugetlb_register_node() error path

2021-01-07 Thread Miaohe Lin
On 2021/1/8 7:15, Andrew Morton wrote: > On Thu, 7 Jan 2021 11:59:38 -0800 Mike Kravetz > wrote: > >> On 1/7/21 4:32 AM, Miaohe Lin wrote: >>> In hugetlb_sysfs_add_hstate(), we would do kobject_put() on hstate_kobjs >>> when failed to create sysfs group but forget to set hstate_kobjs to NULL. >>

Re: [PATCH] mm/hugetlb: Fix potential double free in hugetlb_register_node() error path

2021-01-07 Thread Andrew Morton
On Thu, 7 Jan 2021 11:59:38 -0800 Mike Kravetz wrote: > On 1/7/21 4:32 AM, Miaohe Lin wrote: > > In hugetlb_sysfs_add_hstate(), we would do kobject_put() on hstate_kobjs > > when failed to create sysfs group but forget to set hstate_kobjs to NULL. > > Then in hugetlb_register_node() error path, w

Re: [PATCH] mm/hugetlb: Fix potential double free in hugetlb_register_node() error path

2021-01-07 Thread Mike Kravetz
On 1/7/21 4:32 AM, Miaohe Lin wrote: > In hugetlb_sysfs_add_hstate(), we would do kobject_put() on hstate_kobjs > when failed to create sysfs group but forget to set hstate_kobjs to NULL. > Then in hugetlb_register_node() error path, we may free it again via > hugetlb_unregister_node(). > > Fixes:

[PATCH] mm/hugetlb: Fix potential double free in hugetlb_register_node() error path

2021-01-07 Thread Miaohe Lin
In hugetlb_sysfs_add_hstate(), we would do kobject_put() on hstate_kobjs when failed to create sysfs group but forget to set hstate_kobjs to NULL. Then in hugetlb_register_node() error path, we may free it again via hugetlb_unregister_node(). Fixes: a3437870160c ("hugetlb: new sysfs interface") Si