Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

Hello all: Shall I send patch v2 for it? (if really need, please let me know, and I shall try). Default, I shall continue to try to find and send another patches for mm in "include/linux/*.h". Thanks. On 5/3/16 00:38, Chen Gang wrote: > On 5/3/16 00:23, Chen Gang wrote: >> On 5/2/16 23:35,

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

Hello all: Shall I send patch v2 for it? (if really need, please let me know, and I shall try). Default, I shall continue to try to find and send another patches for mm in "include/linux/*.h". Thanks. On 5/3/16 00:38, Chen Gang wrote: > On 5/3/16 00:23, Chen Gang wrote: >> On 5/2/16 23:35,

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/3/16 00:23, Chen Gang wrote: > On 5/2/16 23:35, Alexander Potapenko wrote: >> On Mon, May 2, 2016 at 5:13 PM, Chen Gang wrote: >>> >>> OK. But it does not look quite easy to use kasan_disable_current() for >>> INIT_KASAN which is used in INIT_TASK. >>> >>> If we

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/3/16 00:23, Chen Gang wrote: > On 5/2/16 23:35, Alexander Potapenko wrote: >> On Mon, May 2, 2016 at 5:13 PM, Chen Gang wrote: >>> >>> OK. But it does not look quite easy to use kasan_disable_current() for >>> INIT_KASAN which is used in INIT_TASK. >>> >>> If we have to set "kasan_depth ==

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 23:35, Alexander Potapenko wrote: > On Mon, May 2, 2016 at 5:13 PM, Chen Gang wrote: >> >> OK. But it does not look quite easy to use kasan_disable_current() for >> INIT_KASAN which is used in INIT_TASK. >> >> If we have to set "kasan_depth == 1", we have to

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 23:35, Alexander Potapenko wrote: > On Mon, May 2, 2016 at 5:13 PM, Chen Gang wrote: >> >> OK. But it does not look quite easy to use kasan_disable_current() for >> INIT_KASAN which is used in INIT_TASK. >> >> If we have to set "kasan_depth == 1", we have to use kasan_depth-- in >>

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 5:13 PM, Chen Gang wrote: > On 5/2/16 22:23, Alexander Potapenko wrote: >> On Mon, May 2, 2016 at 3:51 PM, Chen Gang wrote: >>> >>> OK, thanks. >>> >>> And for "kasan_depth == 1", I guess, its meaning is related with

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 5:13 PM, Chen Gang wrote: > On 5/2/16 22:23, Alexander Potapenko wrote: >> On Mon, May 2, 2016 at 3:51 PM, Chen Gang wrote: >>> >>> OK, thanks. >>> >>> And for "kasan_depth == 1", I guess, its meaning is related with >>> kasan_depth[++|--] in kasan_[en|dis]able_current():

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 22:23, Alexander Potapenko wrote: > On Mon, May 2, 2016 at 3:51 PM, Chen Gang wrote: >> >> OK, thanks. >> >> And for "kasan_depth == 1", I guess, its meaning is related with >> kasan_depth[++|--] in kasan_[en|dis]able_current(): > Assuming you are talking

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 22:23, Alexander Potapenko wrote: > On Mon, May 2, 2016 at 3:51 PM, Chen Gang wrote: >> >> OK, thanks. >> >> And for "kasan_depth == 1", I guess, its meaning is related with >> kasan_depth[++|--] in kasan_[en|dis]able_current(): > Assuming you are talking about the assignment of 1 to

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 3:51 PM, Chen Gang wrote: > On 5/2/16 20:42, Alexander Potapenko wrote: >> On Mon, May 2, 2016 at 2:27 PM, Chen Gang wrote: >>> On 5/2/16 19:21, Dmitry Vyukov wrote: Signed counter looks good to me. >>> >>>

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 3:51 PM, Chen Gang wrote: > On 5/2/16 20:42, Alexander Potapenko wrote: >> On Mon, May 2, 2016 at 2:27 PM, Chen Gang wrote: >>> On 5/2/16 19:21, Dmitry Vyukov wrote: Signed counter looks good to me. >>> >>> Oh, sorry, it seems a little mess (originally, I need

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 20:42, Alexander Potapenko wrote: > On Mon, May 2, 2016 at 2:27 PM, Chen Gang wrote: >> On 5/2/16 19:21, Dmitry Vyukov wrote: >>> >>> Signed counter looks good to me. >> >> Oh, sorry, it seems a little mess (originally, I need let the 2 patches >> in one patch

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 20:42, Alexander Potapenko wrote: > On Mon, May 2, 2016 at 2:27 PM, Chen Gang wrote: >> On 5/2/16 19:21, Dmitry Vyukov wrote: >>> >>> Signed counter looks good to me. >> >> Oh, sorry, it seems a little mess (originally, I need let the 2 patches >> in one patch set). >> >> If what

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 2:27 PM, Chen Gang wrote: > On 5/2/16 19:21, Dmitry Vyukov wrote: >> On Mon, May 2, 2016 at 1:11 PM, Chen Gang wrote: >>> On 5/2/16 16:26, Dmitry Vyukov wrote: If you want to improve kasan_depth handling, then

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 2:27 PM, Chen Gang wrote: > On 5/2/16 19:21, Dmitry Vyukov wrote: >> On Mon, May 2, 2016 at 1:11 PM, Chen Gang wrote: >>> On 5/2/16 16:26, Dmitry Vyukov wrote: If you want to improve kasan_depth handling, then please fix the comments and make disable increment

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 19:21, Dmitry Vyukov wrote: > On Mon, May 2, 2016 at 1:11 PM, Chen Gang wrote: >> On 5/2/16 16:26, Dmitry Vyukov wrote: >>> If you want to improve kasan_depth handling, then please fix the >>> comments and make disable increment and enable decrement

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 19:21, Dmitry Vyukov wrote: > On Mon, May 2, 2016 at 1:11 PM, Chen Gang wrote: >> On 5/2/16 16:26, Dmitry Vyukov wrote: >>> If you want to improve kasan_depth handling, then please fix the >>> comments and make disable increment and enable decrement (potentially >>> with WARNING on

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 19:34, Alexander Potapenko wrote: > On Mon, May 2, 2016 at 7:36 AM, wrote: >> From: Chen Gang >> >> According to kasan_[dis|en]able_current() comments and the kasan_depth' >> s initialization, if kasan_depth is zero, it means

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 19:34, Alexander Potapenko wrote: > On Mon, May 2, 2016 at 7:36 AM, wrote: >> From: Chen Gang >> >> According to kasan_[dis|en]able_current() comments and the kasan_depth' >> s initialization, if kasan_depth is zero, it means disable. > The comments for those functions are really

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 7:36 AM, wrote: > From: Chen Gang > > According to kasan_[dis|en]able_current() comments and the kasan_depth' > s initialization, if kasan_depth is zero, it means disable. The comments for those functions are really

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 7:36 AM, wrote: > From: Chen Gang > > According to kasan_[dis|en]able_current() comments and the kasan_depth' > s initialization, if kasan_depth is zero, it means disable. The comments for those functions are really poor, but there's nothing there that says kasan_depth==0

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 1:11 PM, Chen Gang wrote: > On 5/2/16 16:26, Dmitry Vyukov wrote: >> On Mon, May 2, 2016 at 7:36 AM, wrote: >>> From: Chen Gang >>> >>> According to kasan_[dis|en]able_current() comments and

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 1:11 PM, Chen Gang wrote: > On 5/2/16 16:26, Dmitry Vyukov wrote: >> On Mon, May 2, 2016 at 7:36 AM, wrote: >>> From: Chen Gang >>> >>> According to kasan_[dis|en]able_current() comments and the kasan_depth' >>> s initialization, if kasan_depth is zero, it means disable.

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 16:26, Dmitry Vyukov wrote: > On Mon, May 2, 2016 at 7:36 AM, wrote: >> From: Chen Gang >> >> According to kasan_[dis|en]able_current() comments and the kasan_depth' >> s initialization, if kasan_depth is zero, it means disable. >>

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On 5/2/16 16:26, Dmitry Vyukov wrote: > On Mon, May 2, 2016 at 7:36 AM, wrote: >> From: Chen Gang >> >> According to kasan_[dis|en]able_current() comments and the kasan_depth' >> s initialization, if kasan_depth is zero, it means disable. >> >> So need use "!!kasan_depth" instead of

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 7:36 AM, wrote: > From: Chen Gang > > According to kasan_[dis|en]able_current() comments and the kasan_depth' > s initialization, if kasan_depth is zero, it means disable. > > So need use "!!kasan_depth" instead of

Re: [PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

On Mon, May 2, 2016 at 7:36 AM, wrote: > From: Chen Gang > > According to kasan_[dis|en]able_current() comments and the kasan_depth' > s initialization, if kasan_depth is zero, it means disable. > > So need use "!!kasan_depth" instead of "!kasan_depth" for checking > enable. > > Signed-off-by:

[PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

From: Chen Gang According to kasan_[dis|en]able_current() comments and the kasan_depth' s initialization, if kasan_depth is zero, it means disable. So need use "!!kasan_depth" instead of "!kasan_depth" for checking enable. Signed-off-by: Chen Gang

[PATCH] mm/kasan/kasan.h: Fix boolean checking issue for kasan_report_enabled()

From: Chen Gang According to kasan_[dis|en]able_current() comments and the kasan_depth' s initialization, if kasan_depth is zero, it means disable. So need use "!!kasan_depth" instead of "!kasan_depth" for checking enable. Signed-off-by: Chen Gang --- mm/kasan/kasan.h | 2 +- 1 file changed,