Re: [PATCH] mm/list_lru: optimize condition of exiting the loop

2020-10-27 Thread Hui Su
On Tue, Oct 27, 2020 at 07:45:53PM +0100, Vlastimil Babka wrote: > On 10/27/20 6:04 PM, Hui Su wrote: > > In list_lru_walk(), nr_to_walk type is 'unsigned long', > > so nr_to_walk won't be '< 0'. > > > > In list_lru_walk_node(), nr_to_walk type is 'unsigned long', > > so *nr_to_walk won't be '<

Re: [PATCH] mm/list_lru: optimize condition of exiting the loop

2020-10-27 Thread Vlastimil Babka
On 10/27/20 6:04 PM, Hui Su wrote: In list_lru_walk(), nr_to_walk type is 'unsigned long', so nr_to_walk won't be '< 0'. In list_lru_walk_node(), nr_to_walk type is 'unsigned long', so *nr_to_walk won't be '< 0' too. We can use '!nr_to_walk' instead of 'nr_to_walk <= 0', which is more precise.

[PATCH] mm/list_lru: optimize condition of exiting the loop

2020-10-27 Thread Hui Su
In list_lru_walk(), nr_to_walk type is 'unsigned long', so nr_to_walk won't be '< 0'. In list_lru_walk_node(), nr_to_walk type is 'unsigned long', so *nr_to_walk won't be '< 0' too. We can use '!nr_to_walk' instead of 'nr_to_walk <= 0', which is more precise. Signed-off-by: Hui Su ---