Re: [PATCH] mm/memblock: validate the creation of debugfs files

2015-08-17 Thread Andrew Morton
On Sat, 15 Aug 2015 09:07:30 -0700 Greg Kroah-Hartman wrote: > > > in the kernel/kprobes and etc.), besides this, the memblock API is used > > > mostly at early stage, so we will have some output if something going > > > wrong. > > > > The debugfs error-handling rules are something Greg cooked

Re: [PATCH] mm/memblock: validate the creation of debugfs files

2015-08-15 Thread Greg Kroah-Hartman
On Sat, Aug 15, 2015 at 12:38:30AM -0700, Andrew Morton wrote: > On Sat, 15 Aug 2015 13:26:36 +0600 Alexander Kuleshov > wrote: > > > Hello Andrew, > > > > On 08-14-15, Andrew Morton wrote: > > > On Sat, 15 Aug 2015 01:03:31 +0600 Alexander Kuleshov > > > wrote: > > > > > > > Signed-off-by:

Re: [PATCH] mm/memblock: validate the creation of debugfs files

2015-08-15 Thread Andrew Morton
On Sat, 15 Aug 2015 13:48:50 +0600 Alexander Kuleshov wrote: > On 08-15-15, Andrew Morton wrote: > > Yes, I agree that if memblock's debugfs_create_file() fails, we want to > > know about it because something needs fixing. But that's true of > > all(?) debugfs_create_file callsites, so it's a b

Re: [PATCH] mm/memblock: validate the creation of debugfs files

2015-08-15 Thread Alexander Kuleshov
On 08-15-15, Andrew Morton wrote: > Yes, I agree that if memblock's debugfs_create_file() fails, we want to > know about it because something needs fixing. But that's true of > all(?) debugfs_create_file callsites, so it's a bit silly to add > warnings to them all. Why not put the warning into >

Re: [PATCH] mm/memblock: validate the creation of debugfs files

2015-08-15 Thread Andrew Morton
On Sat, 15 Aug 2015 13:26:36 +0600 Alexander Kuleshov wrote: > Hello Andrew, > > On 08-14-15, Andrew Morton wrote: > > On Sat, 15 Aug 2015 01:03:31 +0600 Alexander Kuleshov > > wrote: > > > > > Signed-off-by: Alexander Kuleshov > > > > There's no changelog. > > Yes, will add it if there w

Re: [PATCH] mm/memblock: validate the creation of debugfs files

2015-08-15 Thread Alexander Kuleshov
Hello Andrew, On 08-14-15, Andrew Morton wrote: > On Sat, 15 Aug 2015 01:03:31 +0600 Alexander Kuleshov > wrote: > > > Signed-off-by: Alexander Kuleshov > > There's no changelog. Yes, will add it if there will be sense in the patch. > > Why? Ignoring the debugfs API return values is stand

Re: [PATCH] mm/memblock: validate the creation of debugfs files

2015-08-14 Thread Andrew Morton
On Sat, 15 Aug 2015 01:03:31 +0600 Alexander Kuleshov wrote: > Signed-off-by: Alexander Kuleshov There's no changelog. > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1692,16 +1692,34 @@ static const struct file_operations > memblock_debug_fops = { > > static int __init memblock_init_de

Re: [PATCH] mm/memblock: validate the creation of debugfs files

2015-08-14 Thread Alexander Kuleshov
On 08-15-15, Alexander Kuleshov wrote: > Signed-off-by: Alexander Kuleshov > --- > mm/memblock.c | 24 +--- > 1 file changed, 21 insertions(+), 3 deletions(-) > Sorry for noise, skip the first patch please. -- To unsubscribe from this list: send the line "unsubscribe linux-ke

[PATCH] mm/memblock: validate the creation of debugfs files

2015-08-14 Thread Alexander Kuleshov
Signed-off-by: Alexander Kuleshov --- mm/memblock.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index 87108e7..c09e911 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1692,16 +1692,34 @@ static const struct file_op

[PATCH] mm/memblock: validate the creation of debugfs files

2015-08-14 Thread Alexander Kuleshov
Signed-off-by: Alexander Kuleshov --- mm/memblock.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index 87108e7..c09e911 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1692,16 +1692,34 @@ static const struct file_op