On Mon 04-01-21 15:23:57, Andrew Morton wrote:
> On Wed, 30 Dec 2020 12:42:33 + Matthew Wilcox wrote:
>
> > On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote:
> > > local variable node_order do not need the static here.
> >
> > It bloody well does. It can be up to 2^10 entries on x86
On Mon, Jan 04, 2021 at 03:23:57PM -0800, Andrew Morton wrote:
> On Wed, 30 Dec 2020 12:42:33 + Matthew Wilcox wrote:
>
> > On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote:
> > > local variable node_order do not need the static here.
> >
> > It bloody well does. It can be up to 2^10
On Wed, 30 Dec 2020 12:42:33 + Matthew Wilcox wrote:
> On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote:
> > local variable node_order do not need the static here.
>
> It bloody well does. It can be up to 2^10 entries on x86 (and larger
> on others) That's 4kB which you've now moved
On Wed 30-12-20 21:41:30, Muchun Song wrote:
> On Wed, Dec 30, 2020 at 8:45 PM Matthew Wilcox wrote:
> >
> > On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote:
> > > local variable node_order do not need the static here.
> >
> > It bloody well does. It can be up to 2^10 entries on x86 (and
On Wed, Dec 30, 2020 at 8:45 PM Matthew Wilcox wrote:
>
> On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote:
> > local variable node_order do not need the static here.
>
> It bloody well does. It can be up to 2^10 entries on x86 (and larger
> on others) That's 4kB which you've now moved
Hi, Matthew:
On Wed, Dec 30, 2020 at 12:42:33PM +, Matthew Wilcox wrote:
> On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote:
> > local variable node_order do not need the static here.
>
> It bloody well does. It can be up to 2^10 entries on x86 (and larger
> on others) That's 4kB
On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote:
> local variable node_order do not need the static here.
It bloody well does. It can be up to 2^10 entries on x86 (and larger
on others) That's 4kB which you've now moved onto the stack.
Please, learn more about what you're doing. I
local variable node_order do not need the static here.
Signed-off-by: Hui Su
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index bdbec4c98173..45e049ccf117 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5864,7
8 matches
Mail list logo