Re: [PATCH] mm/vmscan: fix highidx argument type

2015-01-16 Thread Vlastimil Babka
On 01/16/2015 07:53 PM, Vlastimil Babka wrote: > BTW, I wonder if the whole code couldn't be much simpler by capping > high_zoneidx > by ZONE_NORMAL before traversing the zonelist, like this: > > int high_zoneidx = min(gfp_zone(gfp_mask), ZONE_NORMAL); > > first_zones_zonelist(zonelist,

Re: [PATCH] mm/vmscan: fix highidx argument type

2015-01-16 Thread Vlastimil Babka
On 01/16/2015 08:07 AM, Michael S. Tsirkin wrote: > On Thu, Jan 15, 2015 at 02:49:20PM -0800, Andrew Morton wrote: >> On Fri, 16 Jan 2015 00:18:12 +0200 "Michael S. Tsirkin" >> wrote: >> >> > for_each_zone_zonelist_nodemask wants an enum zone_type >> > argument, but is passed gfp_t: >> > >> >

Re: [PATCH] mm/vmscan: fix highidx argument type

2015-01-16 Thread Vlastimil Babka
On 01/16/2015 08:07 AM, Michael S. Tsirkin wrote: On Thu, Jan 15, 2015 at 02:49:20PM -0800, Andrew Morton wrote: On Fri, 16 Jan 2015 00:18:12 +0200 Michael S. Tsirkin m...@redhat.com wrote: for_each_zone_zonelist_nodemask wants an enum zone_type argument, but is passed gfp_t:

Re: [PATCH] mm/vmscan: fix highidx argument type

2015-01-16 Thread Vlastimil Babka
On 01/16/2015 07:53 PM, Vlastimil Babka wrote: BTW, I wonder if the whole code couldn't be much simpler by capping high_zoneidx by ZONE_NORMAL before traversing the zonelist, like this: int high_zoneidx = min(gfp_zone(gfp_mask), ZONE_NORMAL); first_zones_zonelist(zonelist, high_zoneidx,

Re: [PATCH] mm/vmscan: fix highidx argument type

2015-01-15 Thread Michael S. Tsirkin
On Thu, Jan 15, 2015 at 02:49:20PM -0800, Andrew Morton wrote: > On Fri, 16 Jan 2015 00:18:12 +0200 "Michael S. Tsirkin" > wrote: > > > for_each_zone_zonelist_nodemask wants an enum zone_type > > argument, but is passed gfp_t: > > > > mm/vmscan.c:2658:9:expected int enum zone_type [signed]

Re: [PATCH] mm/vmscan: fix highidx argument type

2015-01-15 Thread Andrew Morton
On Fri, 16 Jan 2015 00:18:12 +0200 "Michael S. Tsirkin" wrote: > for_each_zone_zonelist_nodemask wants an enum zone_type > argument, but is passed gfp_t: > > mm/vmscan.c:2658:9:expected int enum zone_type [signed] highest_zoneidx > mm/vmscan.c:2658:9:got restricted gfp_t [usertype]

[PATCH] mm/vmscan: fix highidx argument type

2015-01-15 Thread Michael S. Tsirkin
for_each_zone_zonelist_nodemask wants an enum zone_type argument, but is passed gfp_t: mm/vmscan.c:2658:9:expected int enum zone_type [signed] highest_zoneidx mm/vmscan.c:2658:9:got restricted gfp_t [usertype] gfp_mask mm/vmscan.c:2658:9: warning: incorrect type in argument 2 (different

[PATCH] mm/vmscan: fix highidx argument type

2015-01-15 Thread Michael S. Tsirkin
for_each_zone_zonelist_nodemask wants an enum zone_type argument, but is passed gfp_t: mm/vmscan.c:2658:9:expected int enum zone_type [signed] highest_zoneidx mm/vmscan.c:2658:9:got restricted gfp_t [usertype] gfp_mask mm/vmscan.c:2658:9: warning: incorrect type in argument 2 (different

Re: [PATCH] mm/vmscan: fix highidx argument type

2015-01-15 Thread Andrew Morton
On Fri, 16 Jan 2015 00:18:12 +0200 Michael S. Tsirkin m...@redhat.com wrote: for_each_zone_zonelist_nodemask wants an enum zone_type argument, but is passed gfp_t: mm/vmscan.c:2658:9:expected int enum zone_type [signed] highest_zoneidx mm/vmscan.c:2658:9:got restricted gfp_t

Re: [PATCH] mm/vmscan: fix highidx argument type

2015-01-15 Thread Michael S. Tsirkin
On Thu, Jan 15, 2015 at 02:49:20PM -0800, Andrew Morton wrote: On Fri, 16 Jan 2015 00:18:12 +0200 Michael S. Tsirkin m...@redhat.com wrote: for_each_zone_zonelist_nodemask wants an enum zone_type argument, but is passed gfp_t: mm/vmscan.c:2658:9:expected int enum zone_type