Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-31 Thread Ingo Molnar
* Borislav Petkov wrote: > On Sun, Mar 29, 2015 at 10:51:22AM +0200, Ingo Molnar wrote: > > s/reduces the mmapped file's entropy by 3 bits > > > > Which does: > > > > - a grammar fix > > > > - measure it in bits, as later on we are talking about randomness in > >bits as well. > >

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-31 Thread Ingo Molnar
* Borislav Petkov b...@alien8.de wrote: On Sun, Mar 29, 2015 at 10:51:22AM +0200, Ingo Molnar wrote: s/reduces the mmapped file's entropy by 3 bits Which does: - a grammar fix - measure it in bits, as later on we are talking about randomness in bits as well. Fixed.

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-29 Thread Borislav Petkov
On Sun, Mar 29, 2015 at 10:51:22AM +0200, Ingo Molnar wrote: > s/reduces the mmapped file's entropy by 3 bits > > Which does: > > - a grammar fix > > - measure it in bits, as later on we are talking about randomness in >bits as well. Fixed. > Btw., does this limitation affect both

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-29 Thread Ingo Molnar
* Borislav Petkov wrote: > From: Hector Marco-Gisbert > Date: Fri, 27 Mar 2015 12:38:21 +0100 > Subject: [PATCH] x86/mm: Improve AMD Bulldozer ASLR fix > > The ASLR implementation needs to special-case AMD F15h processors by > clearing out bits [14:12] of the virtual address in order to avoid

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-29 Thread Ingo Molnar
* Borislav Petkov b...@alien8.de wrote: From: Hector Marco-Gisbert hecma...@upv.es Date: Fri, 27 Mar 2015 12:38:21 +0100 Subject: [PATCH] x86/mm: Improve AMD Bulldozer ASLR fix The ASLR implementation needs to special-case AMD F15h processors by clearing out bits [14:12] of the virtual

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-29 Thread Borislav Petkov
On Sun, Mar 29, 2015 at 10:51:22AM +0200, Ingo Molnar wrote: s/reduces the mmapped file's entropy by 3 bits Which does: - a grammar fix - measure it in bits, as later on we are talking about randomness in bits as well. Fixed. Btw., does this limitation affect both executable

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-28 Thread Kees Cook
On Fri, Mar 27, 2015 at 7:44 AM, Borislav Petkov wrote: > On Fri, Mar 27, 2015 at 12:38:21PM +0100, Hector Marco-Gisbert wrote: >> A bug in Linux ASLR implementation which affects some AMD processors has been >> found. The issue affects to all Linux process even if they are not using >> shared

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-28 Thread Kees Cook
On Fri, Mar 27, 2015 at 7:44 AM, Borislav Petkov b...@alien8.de wrote: On Fri, Mar 27, 2015 at 12:38:21PM +0100, Hector Marco-Gisbert wrote: A bug in Linux ASLR implementation which affects some AMD processors has been found. The issue affects to all Linux process even if they are not using

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-27 Thread Hector Marco-Gisbert
Signed-off-by: Hector Marco-Gisbert Signed-off-by: Ismael Ripoll How am I to interpret Ismael's SOB here? Did he write the patch, did he create it, ...? Because this SOB chain is incorrect in this form. We have only one author per commit. If you want to accredit Ismael, you can say:

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-27 Thread Borislav Petkov
On Fri, Mar 27, 2015 at 12:38:21PM +0100, Hector Marco-Gisbert wrote: > A bug in Linux ASLR implementation which affects some AMD processors has been > found. The issue affects to all Linux process even if they are not using > shared libraries (statically compiled). ... > Signed-off-by: Hector

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-27 Thread Borislav Petkov
On Fri, Mar 27, 2015 at 01:14:48PM +0100, Ingo Molnar wrote: > It's not a bug, it's a feature: to work around a Bulldozer cache > aliasing performance problem we have to keep bits 12,13,14 equal for > all mappings in the system. > > Your patch improves upon that fix: by per-boot randomizing the >

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-27 Thread Ingo Molnar
* Hector Marco-Gisbert wrote: > A bug in Linux ASLR implementation which affects some AMD processors > has been found. The issue affects to all Linux process even if they > are not using shared libraries (statically compiled). It's not a bug, it's a feature: to work around a Bulldozer cache

[PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-27 Thread Hector Marco-Gisbert
A bug in Linux ASLR implementation which affects some AMD processors has been found. The issue affects to all Linux process even if they are not using shared libraries (statically compiled). The problem appears because some mmapped objects (VDSO, libraries, etc.) are poorly randomized in an

[PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-27 Thread Hector Marco-Gisbert
A bug in Linux ASLR implementation which affects some AMD processors has been found. The issue affects to all Linux process even if they are not using shared libraries (statically compiled). The problem appears because some mmapped objects (VDSO, libraries, etc.) are poorly randomized in an

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-27 Thread Ingo Molnar
* Hector Marco-Gisbert hecma...@upv.es wrote: A bug in Linux ASLR implementation which affects some AMD processors has been found. The issue affects to all Linux process even if they are not using shared libraries (statically compiled). It's not a bug, it's a feature: to work around a

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-27 Thread Borislav Petkov
On Fri, Mar 27, 2015 at 01:14:48PM +0100, Ingo Molnar wrote: It's not a bug, it's a feature: to work around a Bulldozer cache aliasing performance problem we have to keep bits 12,13,14 equal for all mappings in the system. Your patch improves upon that fix: by per-boot randomizing the

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-27 Thread Borislav Petkov
On Fri, Mar 27, 2015 at 12:38:21PM +0100, Hector Marco-Gisbert wrote: A bug in Linux ASLR implementation which affects some AMD processors has been found. The issue affects to all Linux process even if they are not using shared libraries (statically compiled). ... Signed-off-by: Hector

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-27 Thread Hector Marco-Gisbert
Signed-off-by: Hector Marco-Gisbert hecma...@upv.es Signed-off-by: Ismael Ripoll irip...@disca.upv.es How am I to interpret Ismael's SOB here? Did he write the patch, did he create it, ...? Because this SOB chain is incorrect in this form. We have only one author per commit. If you want to

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-26 Thread Borislav Petkov
On Wed, Mar 25, 2015 at 07:36:17PM +0100, Hector Marco-Gisbert wrote: > A bug in Linux ASLR implementation which affects some AMD processors has been > found. The issue affects to all Linux process even if they are not using > shared libraries (statically compiled). > > The problem appears

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-26 Thread Borislav Petkov
On Wed, Mar 25, 2015 at 07:36:17PM +0100, Hector Marco-Gisbert wrote: A bug in Linux ASLR implementation which affects some AMD processors has been found. The issue affects to all Linux process even if they are not using shared libraries (statically compiled). The problem appears because

[PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-25 Thread Hector Marco-Gisbert
A bug in Linux ASLR implementation which affects some AMD processors has been found. The issue affects to all Linux process even if they are not using shared libraries (statically compiled). The problem appears because some mmapped objects (VDSO, libraries, etc.) are poorly randomized in an

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-25 Thread Hector Marco
El 24/03/15 a las 20:15, Borislav Petkov escribió: On Tue, Mar 24, 2015 at 07:00:48PM +0100, Hector Marco-Gisbert wrote: diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index 15c5df9..a693d54 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -5,6

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-25 Thread Hector Marco
El 24/03/15 a las 20:15, Borislav Petkov escribió: On Tue, Mar 24, 2015 at 07:00:48PM +0100, Hector Marco-Gisbert wrote: diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index 15c5df9..a693d54 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -5,6

[PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-25 Thread Hector Marco-Gisbert
A bug in Linux ASLR implementation which affects some AMD processors has been found. The issue affects to all Linux process even if they are not using shared libraries (statically compiled). The problem appears because some mmapped objects (VDSO, libraries, etc.) are poorly randomized in an

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-24 Thread Borislav Petkov
On Tue, Mar 24, 2015 at 07:00:48PM +0100, Hector Marco-Gisbert wrote: > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > index 15c5df9..a693d54 100644 > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -5,6 +5,7 @@ > > #include > #include > +#include

[PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-24 Thread Hector Marco-Gisbert
A bug in Linux ASLR implementation which affects some AMD processors has been found. The issue affects to all Linux process even if they are not using shared libraries (statically compiled). The problem appears because some mmapped objects (VDSO, libraries, etc.) are poorly randomized in an

[PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-24 Thread Hector Marco-Gisbert
A bug in Linux ASLR implementation which affects some AMD processors has been found. The issue affects to all Linux process even if they are not using shared libraries (statically compiled). The problem appears because some mmapped objects (VDSO, libraries, etc.) are poorly randomized in an

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-24 Thread Borislav Petkov
On Tue, Mar 24, 2015 at 07:00:48PM +0100, Hector Marco-Gisbert wrote: diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index 15c5df9..a693d54 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -5,6 +5,7 @@ #include linux/io.h #include