Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning

2017-05-25 Thread Nick Desaulniers
On Wed, May 24, 2017 at 05:16:18PM +0900, Sergey Senozhatsky wrote: > On (05/23/17 22:38), Nick Desaulniers wrote: > > Fixes the following warning, found with Clang: > well, no objections from my side. MM seems to be getting more and > more `__maybe_unused' annotations because of clang. Indeed, bu

Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning

2017-05-24 Thread Minchan Kim
On Tue, May 23, 2017 at 10:38:57PM -0700, Nick Desaulniers wrote: > is_first_page() is only called from the macro VM_BUG_ON_PAGE() which is > only compiled in as a runtime check when CONFIG_DEBUG_VM is set, > otherwise is checked at compile time and not actually compiled in. > > Fixes the followin

Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning

2017-05-24 Thread Sergey Senozhatsky
On (05/23/17 22:38), Nick Desaulniers wrote: > > is_first_page() is only called from the macro VM_BUG_ON_PAGE() which is > only compiled in as a runtime check when CONFIG_DEBUG_VM is set, > otherwise is checked at compile time and not actually compiled in. > > Fixes the following warning, found w

[PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning

2017-05-23 Thread Nick Desaulniers
is_first_page() is only called from the macro VM_BUG_ON_PAGE() which is only compiled in as a runtime check when CONFIG_DEBUG_VM is set, otherwise is checked at compile time and not actually compiled in. Fixes the following warning, found with Clang: mm/zsmalloc.c:472:12: warning: function 'is_fi