Re: [PATCH] mm: Fix overflow check in expand_upwards()

2017-06-30 Thread Jörn Engel
On Fri, Jun 30, 2017 at 09:34:24AM +0200, Helge Deller wrote: > > I see there are some architectures which define TASK_SIZE not as > multiple of PAGE_SIZE and as 0x for which the (address >= > TASK_SIZE) check will not trigger: > > arch/arm/include/asm/memory.h:#define TASK_SIZE U

Re: [PATCH] mm: Fix overflow check in expand_upwards()

2017-06-30 Thread Jörn Engel
On Fri, Jun 30, 2017 at 08:57:27AM +0200, Helge Deller wrote: > On 30.06.2017 01:02, Jörn Engel wrote: > > I believe the overflow check was correct, then got subtly broken by > > commit bd726c90b6b8 > > Author: Helge Deller > > Date: Mon Jun 19 17:34:05 2017 +0200 > > > > Al

Re: [PATCH] mm: Fix overflow check in expand_upwards()

2017-06-30 Thread Helge Deller
* Helge Deller : > On 30.06.2017 01:02, Jörn Engel wrote: > > I believe the overflow check was correct, then got subtly broken by > > commit bd726c90b6b8 > > Author: Helge Deller > > Date: Mon Jun 19 17:34:05 2017 +0200 > > > > Allow stack to grow up to address space limit >

Re: [PATCH] mm: Fix overflow check in expand_upwards()

2017-06-29 Thread Helge Deller
On 30.06.2017 01:02, Jörn Engel wrote: > I believe the overflow check was correct, then got subtly broken by > commit bd726c90b6b8 > Author: Helge Deller > Date: Mon Jun 19 17:34:05 2017 +0200 > > Allow stack to grow up to address space limit > > The old overflow ch

[PATCH] mm: Fix overflow check in expand_upwards()

2017-06-29 Thread Jörn Engel
I believe the overflow check was correct, then got subtly broken by commit bd726c90b6b8 Author: Helge Deller Date: Mon Jun 19 17:34:05 2017 +0200 Allow stack to grow up to address space limit The old overflow check may have been a bit subtle and I suppose He