Re: [PATCH] mm: fix page leak at nfs_symlink()

2014-02-07 Thread Rik van Riel
On 02/07/2014 10:19 AM, Rafael Aquini wrote: Changes committed by "a0b8cab3 mm: remove lru parameter from __pagevec_lru_add and remove parts of pagevec API" have introduced a call to add_to_page_cache_lru() which causes a leak in nfs_symlink() as now the page gets an extra refcount that is not

Re: [PATCH] mm: fix page leak at nfs_symlink()

2014-02-07 Thread Mel Gorman
On Fri, Feb 07, 2014 at 01:19:54PM -0200, Rafael Aquini wrote: > Changes committed by "a0b8cab3 mm: remove lru parameter from > __pagevec_lru_add and remove parts of pagevec API" have introduced > a call to add_to_page_cache_lru() which causes a leak in nfs_symlink() > as now the page gets an

Re: [PATCH] mm: fix page leak at nfs_symlink()

2014-02-07 Thread Rafael Aquini
On Fri, Feb 07, 2014 at 10:39:24AM -0500, Jeff Layton wrote: > On Fri, 7 Feb 2014 13:19:54 -0200 > Rafael Aquini wrote: > > > Changes committed by "a0b8cab3 mm: remove lru parameter from > > __pagevec_lru_add and remove parts of pagevec API" have introduced > > a call to add_to_page_cache_lru()

Re: [PATCH] mm: fix page leak at nfs_symlink()

2014-02-07 Thread Jeff Layton
On Fri, 7 Feb 2014 13:19:54 -0200 Rafael Aquini wrote: > Changes committed by "a0b8cab3 mm: remove lru parameter from > __pagevec_lru_add and remove parts of pagevec API" have introduced > a call to add_to_page_cache_lru() which causes a leak in nfs_symlink() > as now the page gets an extra

[PATCH] mm: fix page leak at nfs_symlink()

2014-02-07 Thread Rafael Aquini
Changes committed by "a0b8cab3 mm: remove lru parameter from __pagevec_lru_add and remove parts of pagevec API" have introduced a call to add_to_page_cache_lru() which causes a leak in nfs_symlink() as now the page gets an extra refcount that is not dropped. Jan Stancek observed and reported the

[PATCH] mm: fix page leak at nfs_symlink()

2014-02-07 Thread Rafael Aquini
Changes committed by a0b8cab3 mm: remove lru parameter from __pagevec_lru_add and remove parts of pagevec API have introduced a call to add_to_page_cache_lru() which causes a leak in nfs_symlink() as now the page gets an extra refcount that is not dropped. Jan Stancek observed and reported the

Re: [PATCH] mm: fix page leak at nfs_symlink()

2014-02-07 Thread Jeff Layton
On Fri, 7 Feb 2014 13:19:54 -0200 Rafael Aquini aqu...@redhat.com wrote: Changes committed by a0b8cab3 mm: remove lru parameter from __pagevec_lru_add and remove parts of pagevec API have introduced a call to add_to_page_cache_lru() which causes a leak in nfs_symlink() as now the page gets

Re: [PATCH] mm: fix page leak at nfs_symlink()

2014-02-07 Thread Rafael Aquini
On Fri, Feb 07, 2014 at 10:39:24AM -0500, Jeff Layton wrote: On Fri, 7 Feb 2014 13:19:54 -0200 Rafael Aquini aqu...@redhat.com wrote: Changes committed by a0b8cab3 mm: remove lru parameter from __pagevec_lru_add and remove parts of pagevec API have introduced a call to

Re: [PATCH] mm: fix page leak at nfs_symlink()

2014-02-07 Thread Rik van Riel
On 02/07/2014 10:19 AM, Rafael Aquini wrote: Changes committed by a0b8cab3 mm: remove lru parameter from __pagevec_lru_add and remove parts of pagevec API have introduced a call to add_to_page_cache_lru() which causes a leak in nfs_symlink() as now the page gets an extra refcount that is not

Re: [PATCH] mm: fix page leak at nfs_symlink()

2014-02-07 Thread Mel Gorman
On Fri, Feb 07, 2014 at 01:19:54PM -0200, Rafael Aquini wrote: Changes committed by a0b8cab3 mm: remove lru parameter from __pagevec_lru_add and remove parts of pagevec API have introduced a call to add_to_page_cache_lru() which causes a leak in nfs_symlink() as now the page gets an extra