Re: [PATCH] mm: memcg/slab: fix obj_cgroup_charge() return value handling

2020-11-27 Thread Shakeel Butt
On Fri, Nov 27, 2020 at 8:18 AM Roman Gushchin wrote: > > On Thu, Nov 26, 2020 at 09:55:24PM -0800, Shakeel Butt wrote: > > On Thu, Nov 26, 2020 at 8:14 PM Roman Gushchin wrote: > > > > > > Commit 10befea91b61 ("mm: memcg/slab: use a single set of kmem_caches > > > for all allocations")

Re: [PATCH] mm: memcg/slab: fix obj_cgroup_charge() return value handling

2020-11-27 Thread Roman Gushchin
On Thu, Nov 26, 2020 at 09:55:24PM -0800, Shakeel Butt wrote: > On Thu, Nov 26, 2020 at 8:14 PM Roman Gushchin wrote: > > > > Commit 10befea91b61 ("mm: memcg/slab: use a single set of kmem_caches > > for all allocations") introduced a regression into the handling of the > > obj_cgroup_charge()

Re: [PATCH] mm: memcg/slab: fix obj_cgroup_charge() return value handling

2020-11-26 Thread Shakeel Butt
On Thu, Nov 26, 2020 at 8:14 PM Roman Gushchin wrote: > > Commit 10befea91b61 ("mm: memcg/slab: use a single set of kmem_caches > for all allocations") introduced a regression into the handling of the > obj_cgroup_charge() return value. If a non-zero value is returned > (indicating of exceeding

[PATCH] mm: memcg/slab: fix obj_cgroup_charge() return value handling

2020-11-26 Thread Roman Gushchin
Commit 10befea91b61 ("mm: memcg/slab: use a single set of kmem_caches for all allocations") introduced a regression into the handling of the obj_cgroup_charge() return value. If a non-zero value is returned (indicating of exceeding one of memory.max limits), the allocation should fail, instead of