Re: [PATCH] mm: memcontrol: fix slub memory accounting

2021-02-23 Thread Michal Koutný
On Tue, Feb 23, 2021 at 05:24:23PM +0800, Muchun Song wrote: > mm/slab_common.c | 4 ++-- > mm/slub.c| 8 > 2 files changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Michal Koutný signature.asc Description: Digital signature

Re: [PATCH] mm: memcontrol: fix slub memory accounting

2021-02-23 Thread Roman Gushchin
On Tue, Feb 23, 2021 at 05:24:23PM +0800, Muchun Song wrote: > SLUB currently account kmalloc() and kmalloc_node() allocations larger > than order-1 page per-node. But it forget to update the per-memcg > vmstats. So it can lead to inaccurate statistics of "slab_unreclaimable" > which is from

Re: [PATCH] mm: memcontrol: fix slub memory accounting

2021-02-23 Thread Shakeel Butt
On Tue, Feb 23, 2021 at 1:25 AM Muchun Song wrote: > > SLUB currently account kmalloc() and kmalloc_node() allocations larger > than order-1 page per-node. But it forget to update the per-memcg > vmstats. So it can lead to inaccurate statistics of "slab_unreclaimable" > which is from memory.stat.

[PATCH] mm: memcontrol: fix slub memory accounting

2021-02-23 Thread Muchun Song
SLUB currently account kmalloc() and kmalloc_node() allocations larger than order-1 page per-node. But it forget to update the per-memcg vmstats. So it can lead to inaccurate statistics of "slab_unreclaimable" which is from memory.stat. Fix it by using mod_lruvec_page_state instead of