Re: [PATCH] mm: mmap: remove unnecessary unlikely()

2018-11-04 Thread Michal Hocko
On Sun 04-11-18 07:44:56, Yangtao Li wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to use > unlikely. We should just get rid of this ugliness altogether. It no longer serves its purpose. This is a historical artifact from 2005 where do_brk was called outside of the

Re: [PATCH] mm: mmap: remove unnecessary unlikely()

2018-11-04 Thread Michal Hocko
On Sun 04-11-18 07:44:56, Yangtao Li wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to use > unlikely. We should just get rid of this ugliness altogether. It no longer serves its purpose. This is a historical artifact from 2005 where do_brk was called outside of the

[PATCH] mm: mmap: remove unnecessary unlikely()

2018-11-04 Thread Yangtao Li
WARN_ON() already contains an unlikely(), so it's not necessary to use unlikely. Signed-off-by: Yangtao Li --- mm/mmap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 6c04292e16a7..2077008ade0c 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@

[PATCH] mm: mmap: remove unnecessary unlikely()

2018-11-04 Thread Yangtao Li
WARN_ON() already contains an unlikely(), so it's not necessary to use unlikely. Signed-off-by: Yangtao Li --- mm/mmap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 6c04292e16a7..2077008ade0c 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@