Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-25 Thread Yang Shi
On 7/24/19 7:48 PM, Andrew Morton wrote: On Sat, 13 Jul 2019 04:49:04 +0800 Yang Shi wrote: When running ltp's oom test with kmemleak enabled, the below warning was triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is passed in: ... The mempool_alloc_slab() clears __GFP

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-24 Thread Andrew Morton
On Sat, 13 Jul 2019 04:49:04 +0800 Yang Shi wrote: > When running ltp's oom test with kmemleak enabled, the below warning was > triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is > passed in: > > ... > > The mempool_alloc_slab() clears __GFP_DIRECT_RECLAIM, kmemleak has > __

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-16 Thread Yang Shi
On 7/15/19 8:01 AM, Catalin Marinas wrote: On 15 Jul 2019, at 08:17, Michal Hocko wrote: On Sat 13-07-19 04:49:04, Yang Shi wrote: When running ltp's oom test with kmemleak enabled, the below warning was triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is passed in: kme

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-15 Thread Yang Shi
On 7/15/19 6:06 AM, Matthew Wilcox wrote: On Sun, Jul 14, 2019 at 08:47:07PM -0700, Yang Shi wrote: On 7/13/19 2:25 PM, Matthew Wilcox wrote: On Sat, Jul 13, 2019 at 04:49:04AM +0800, Yang Shi wrote: When running ltp's oom test with kmemleak enabled, the below warning was triggerred since

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-15 Thread Yang Shi
On 7/15/19 8:18 AM, Qian Cai wrote: On Mon, 2019-07-15 at 10:01 -0500, Catalin Marinas wrote: On 15 Jul 2019, at 08:17, Michal Hocko wrote: On Sat 13-07-19 04:49:04, Yang Shi wrote: When running ltp's oom test with kmemleak enabled, the below warning was triggerred since kernel detects __G

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-15 Thread Qian Cai
On Mon, 2019-07-15 at 10:01 -0500, Catalin Marinas wrote: > On 15 Jul 2019, at 08:17, Michal Hocko wrote: > > On Sat 13-07-19 04:49:04, Yang Shi wrote: > > > When running ltp's oom test with kmemleak enabled, the below warning was > > > triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-15 Thread Catalin Marinas
On 15 Jul 2019, at 08:17, Michal Hocko wrote: > On Sat 13-07-19 04:49:04, Yang Shi wrote: >> When running ltp's oom test with kmemleak enabled, the below warning was >> triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is >> passed in: > > kmemleak is broken and this is a long

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-15 Thread Michal Hocko
On Sat 13-07-19 12:39:16, David Rientjes wrote: > On Sat, 13 Jul 2019, Yang Shi wrote: > > > When running ltp's oom test with kmemleak enabled, the below warning was > > triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is > > passed in: > > > > WARNING: CPU: 105 PID: 2138 at m

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-15 Thread Michal Hocko
On Sat 13-07-19 04:49:04, Yang Shi wrote: > When running ltp's oom test with kmemleak enabled, the below warning was > triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is > passed in: kmemleak is broken and this is a long term issue. I thought that Catalin had something to addr

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-15 Thread Matthew Wilcox
On Sun, Jul 14, 2019 at 08:47:07PM -0700, Yang Shi wrote: > > > On 7/13/19 2:25 PM, Matthew Wilcox wrote: > > On Sat, Jul 13, 2019 at 04:49:04AM +0800, Yang Shi wrote: > > > When running ltp's oom test with kmemleak enabled, the below warning was > > > triggerred since kernel detects __GFP_NOFAIL

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-14 Thread Yang Shi
On 7/13/19 12:39 PM, David Rientjes wrote: On Sat, 13 Jul 2019, Yang Shi wrote: When running ltp's oom test with kmemleak enabled, the below warning was triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is passed in: WARNING: CPU: 105 PID: 2138 at mm/page_alloc.c:4608 __

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-14 Thread Yang Shi
On 7/13/19 2:25 PM, Matthew Wilcox wrote: On Sat, Jul 13, 2019 at 04:49:04AM +0800, Yang Shi wrote: When running ltp's oom test with kmemleak enabled, the below warning was triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is passed in: There are lots of places where kmeml

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-13 Thread Matthew Wilcox
On Sat, Jul 13, 2019 at 04:49:04AM +0800, Yang Shi wrote: > When running ltp's oom test with kmemleak enabled, the below warning was > triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is > passed in: There are lots of places where kmemleak will call kmalloc with __GFP_NOFAIL an

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-13 Thread David Rientjes
On Sat, 13 Jul 2019, Yang Shi wrote: > When running ltp's oom test with kmemleak enabled, the below warning was > triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is > passed in: > > WARNING: CPU: 105 PID: 2138 at mm/page_alloc.c:4608 > __alloc_pages_nodemask+0x1c31/0x1d50 >

[PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-12 Thread Yang Shi
When running ltp's oom test with kmemleak enabled, the below warning was triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is passed in: WARNING: CPU: 105 PID: 2138 at mm/page_alloc.c:4608 __alloc_pages_nodemask+0x1c31/0x1d50 Modules linked in: loop dax_pmem dax_pmem_core ip_ta