Re: [PATCH] mm: pagevec: cleanup: drop pvec->cold argument in all places

2013-10-03 Thread Andrew Morton
On Tue, 1 Oct 2013 22:47:36 -0700 (PDT) David Rientjes wrote: > On Mon, 30 Sep 2013, Andrew Morton wrote: > > > > Nobody uses the pvec->cold argument of pagevec and it's also unreasonable > > > for > > > pages in pagevec released as cold page, so drop the cold argument from > > > pagevec. >

Re: [PATCH] mm: pagevec: cleanup: drop pvec-cold argument in all places

2013-10-03 Thread Andrew Morton
On Tue, 1 Oct 2013 22:47:36 -0700 (PDT) David Rientjes rient...@google.com wrote: On Mon, 30 Sep 2013, Andrew Morton wrote: Nobody uses the pvec-cold argument of pagevec and it's also unreasonable for pages in pagevec released as cold page, so drop the cold argument from

Re: [PATCH] mm: pagevec: cleanup: drop pvec->cold argument in all places

2013-10-01 Thread David Rientjes
On Mon, 30 Sep 2013, Andrew Morton wrote: > > Nobody uses the pvec->cold argument of pagevec and it's also unreasonable > > for > > pages in pagevec released as cold page, so drop the cold argument from > > pagevec. > > Is it unreasonable? I'd say it's unreasonable to assume that all pages >

Re: [PATCH] mm: pagevec: cleanup: drop pvec-cold argument in all places

2013-10-01 Thread David Rientjes
On Mon, 30 Sep 2013, Andrew Morton wrote: Nobody uses the pvec-cold argument of pagevec and it's also unreasonable for pages in pagevec released as cold page, so drop the cold argument from pagevec. Is it unreasonable? I'd say it's unreasonable to assume that all pages in all cases

Re: [PATCH] mm: pagevec: cleanup: drop pvec->cold argument in all places

2013-09-30 Thread Andrew Morton
On Sat, 28 Sep 2013 16:33:58 +0800 Bob Liu wrote: > Nobody uses the pvec->cold argument of pagevec and it's also unreasonable for > pages in pagevec released as cold page, so drop the cold argument from > pagevec. Is it unreasonable? I'd say it's unreasonable to assume that all pages in all

Re: [PATCH] mm: pagevec: cleanup: drop pvec-cold argument in all places

2013-09-30 Thread Andrew Morton
On Sat, 28 Sep 2013 16:33:58 +0800 Bob Liu lliu...@gmail.com wrote: Nobody uses the pvec-cold argument of pagevec and it's also unreasonable for pages in pagevec released as cold page, so drop the cold argument from pagevec. Is it unreasonable? I'd say it's unreasonable to assume that all

[PATCH] mm: pagevec: cleanup: drop pvec->cold argument in all places

2013-09-28 Thread Bob Liu
Nobody uses the pvec->cold argument of pagevec and it's also unreasonable for pages in pagevec released as cold page, so drop the cold argument from pagevec. Signed-off-by: Bob Liu --- fs/9p/cache.c |2 +- fs/afs/cache.c |2 +- fs/afs/write.c |4 ++--

[PATCH] mm: pagevec: cleanup: drop pvec-cold argument in all places

2013-09-28 Thread Bob Liu
Nobody uses the pvec-cold argument of pagevec and it's also unreasonable for pages in pagevec released as cold page, so drop the cold argument from pagevec. Signed-off-by: Bob Liu bob@oracle.com --- fs/9p/cache.c |2 +- fs/afs/cache.c |2 +- fs/afs/write.c