Re: [PATCH] mm: remove a redundant condition in the for loop

2017-06-21 Thread Michal Hocko
On Mon 19-06-17 21:05:29, Rasmus Villemoes wrote: > On Mon, Jun 19 2017, Vlastimil Babka wrote: > > > On 06/19/2017 03:54 PM, Hao Lee wrote: > >> The variable current_order decreases from MAX_ORDER-1 to order, so the > >> condition current_order <= MAX_ORDER-1 is always true. >

Re: [PATCH] mm: remove a redundant condition in the for loop

2017-06-21 Thread Michal Hocko
On Mon 19-06-17 21:05:29, Rasmus Villemoes wrote: > On Mon, Jun 19 2017, Vlastimil Babka wrote: > > > On 06/19/2017 03:54 PM, Hao Lee wrote: > >> The variable current_order decreases from MAX_ORDER-1 to order, so the > >> condition current_order <= MAX_ORDER-1 is always true. > >> > >>

Re: [PATCH] mm: remove a redundant condition in the for loop

2017-06-19 Thread Hao Lee
On Tue, Jun 20, 2017 at 3:05 AM, Rasmus Villemoes wrote: > On Mon, Jun 19 2017, Vlastimil Babka wrote: > >> On 06/19/2017 03:54 PM, Hao Lee wrote: >>> The variable current_order decreases from MAX_ORDER-1 to order, so the >>> condition current_order <=

Re: [PATCH] mm: remove a redundant condition in the for loop

2017-06-19 Thread Hao Lee
On Tue, Jun 20, 2017 at 3:05 AM, Rasmus Villemoes wrote: > On Mon, Jun 19 2017, Vlastimil Babka wrote: > >> On 06/19/2017 03:54 PM, Hao Lee wrote: >>> The variable current_order decreases from MAX_ORDER-1 to order, so the >>> condition current_order <= MAX_ORDER-1 is always true. >>> >>>

Re: [PATCH] mm: remove a redundant condition in the for loop

2017-06-19 Thread Vlastimil Babka
On 06/19/2017 09:05 PM, Rasmus Villemoes wrote: > On Mon, Jun 19 2017, Vlastimil Babka wrote: > >> On 06/19/2017 03:54 PM, Hao Lee wrote: >>> The variable current_order decreases from MAX_ORDER-1 to order, so the >>> condition current_order <= MAX_ORDER-1 is always true. >>> >>>

Re: [PATCH] mm: remove a redundant condition in the for loop

2017-06-19 Thread Vlastimil Babka
On 06/19/2017 09:05 PM, Rasmus Villemoes wrote: > On Mon, Jun 19 2017, Vlastimil Babka wrote: > >> On 06/19/2017 03:54 PM, Hao Lee wrote: >>> The variable current_order decreases from MAX_ORDER-1 to order, so the >>> condition current_order <= MAX_ORDER-1 is always true. >>> >>> Signed-off-by:

Re: [PATCH] mm: remove a redundant condition in the for loop

2017-06-19 Thread Rasmus Villemoes
On Mon, Jun 19 2017, Vlastimil Babka wrote: > On 06/19/2017 03:54 PM, Hao Lee wrote: >> The variable current_order decreases from MAX_ORDER-1 to order, so the >> condition current_order <= MAX_ORDER-1 is always true. >> >> Signed-off-by: Hao Lee > >

Re: [PATCH] mm: remove a redundant condition in the for loop

2017-06-19 Thread Rasmus Villemoes
On Mon, Jun 19 2017, Vlastimil Babka wrote: > On 06/19/2017 03:54 PM, Hao Lee wrote: >> The variable current_order decreases from MAX_ORDER-1 to order, so the >> condition current_order <= MAX_ORDER-1 is always true. >> >> Signed-off-by: Hao Lee > > Sounds right. > > Acked-by: Vlastimil Babka

Re: [PATCH] mm: remove a redundant condition in the for loop

2017-06-19 Thread Vlastimil Babka
On 06/19/2017 03:54 PM, Hao Lee wrote: > The variable current_order decreases from MAX_ORDER-1 to order, so the > condition current_order <= MAX_ORDER-1 is always true. > > Signed-off-by: Hao Lee Sounds right. Acked-by: Vlastimil Babka > --- >

Re: [PATCH] mm: remove a redundant condition in the for loop

2017-06-19 Thread Vlastimil Babka
On 06/19/2017 03:54 PM, Hao Lee wrote: > The variable current_order decreases from MAX_ORDER-1 to order, so the > condition current_order <= MAX_ORDER-1 is always true. > > Signed-off-by: Hao Lee Sounds right. Acked-by: Vlastimil Babka > --- > mm/page_alloc.c | 5 ++--- > 1 file changed, 2

[PATCH] mm: remove a redundant condition in the for loop

2017-06-19 Thread Hao Lee
The variable current_order decreases from MAX_ORDER-1 to order, so the condition current_order <= MAX_ORDER-1 is always true. Signed-off-by: Hao Lee --- mm/page_alloc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/page_alloc.c

[PATCH] mm: remove a redundant condition in the for loop

2017-06-19 Thread Hao Lee
The variable current_order decreases from MAX_ORDER-1 to order, so the condition current_order <= MAX_ORDER-1 is always true. Signed-off-by: Hao Lee --- mm/page_alloc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index